---------- Forwarded message ---------- From: Zooko O'Whielacronx <zoo...@gmail.com> Date: Mon, Sep 9, 2013 at 10:33 PM Subject: Re: Ticket #961 To: berta...@ptitcanardnoir.org Cc: Jacob Appelbaum <ja...@appelbaum.net>, Daira Hopwood <da...@leastauthority.com>
Okay, I just reviewed http://anonscm.debian.org/gitweb/?p=tahoe/tahoe.git;a=blob;f=debian/tahoe-lafs.init;h=13b505fb4b2d4be959e3df7edef02a369a48fc7c;hb=8428876521454b5fd2b0719048caf909c0ab68ee . Here are my comments. Thank you for working on this patch! I'm excited about making Tahoe-LAFS be a more first-class citizen of the Debian universe. A lot of good can come of this. Thank you for your contribution. I don't understand why "/etc/init.d/tahoe-lafs restart" does "tahoe stop ; sleep 1 ; tahoe start" and "/etc/init.d/tahoe-lafs force-reload" does "restart". I think both of those should do "tahoe restart". I think "/etc/init.d/tahoe-lafs stop" should do "tahoe stop" instead of "kill `cat twistd.pid`". That's because "tahoe stop" has a couple of features such as warning the user if the daemon doesn't stop after SIGKILL. See the code here: ¹. ¹ https://tahoe-lafs.org/trac/tahoe-lafs/browser/trunk/src/allmydata/scripts/startstop_node.py?annotate=blame&rev=3ee950f09ed8b7f6cc72a98c26eefe9e02c11d85#L78 Other than those two things, I didn't see anything strange or objectionable in this patch. Thanks again! Regards, Zooko -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
