On Thu, Sep 19, 2013 at 11:50 AM, Guido Günther <a...@sigxcpu.org> wrote: >> First of all, thanks for adding support for Ubuntu to the test suite. >> Unfortunately, adding that support actually caused the package to FTBFS on >> Ubuntu due to test failures. Luckily the solution is simple. You forgot to >> remove the work-around for not supporting Ubuntu in the past. >> >> debian/rules exports DEB_VENDOR="Debian" so dch acts like it would under >> Debian >> not Ubuntu, but the tests are correctly detecting that they are being run on >> Ubuntu. > > So we should revert 323bdcfa2f7bfa2f2402c22c4c90ca060243daaf ? > > commit 323bdcfa2f7bfa2f2402c22c4c90ca060243daaf > Author: Dmitrijs Ledkovs <dmitrijs.ledk...@canonical.com> > Date: Sun Nov 4 17:56:29 2012 +0000 > > Fix testsuite failure if DEB_VENDOR != Debian > > The package fails to build from source if the DEB_VENDOR is not Debian, > as the test output from git-dch expects Debian distribution specific > behaviour. > > You can see the failed build log with DEB_VENDOR=Ubuntu here: > > https://launchpadlibrarian.net/121690052/buildlog_ubuntu-raring-i386.git-buildpackage_0.6.0~git20120822_FAILEDTOBUILD.txt.gz > > Closes: #692289
Yes. By exporting DEB_VENDOR="Debian", dch produces changelog versions like "test-package (0.9-2) unstable" while the test expect "test-package (0.9-1ubuntu1) saucy" as the can tell they are being run on Ubuntu. Here's the FTBFS build log for 0.6.3 on Ubuntu: https://launchpadlibrarian.net/149792064/buildlog_ubuntu-saucy-i386.git-buildpackage_0.6.3_FAILEDTOBUILD.txt.gz > Could you check what happens with latest git please? I've tested the latest git with my patch applied in both Ubuntu saucy and Debian sid pbuilders. It builds correctly and all test pass. -- Andrew Starr-Bochicchio Ubuntu Developer <https://launchpad.net/~andrewsomething> Debian Developer <http://qa.debian.org/developer.php?login=asb> PGP/GPG Key ID: D53FDCB1 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
