Hi,

> The new package is at:
> 
>     http://mentors.debian.net/package/youtube-cli

I have reviewed it, and deemed the changes to README.source necessary.
Also, as explained above, your consideration for local copies of
youtube-dl contradict the Debian way.

Attached is a patch that finalizes your packaging work, I think you can
put up your package for sponsorship after applying it (if I were a DD, I
would not upload it if you did not apply the patch).

Fell free to mention my review if posting to debian-mentors. You can use
the template supplied by mentors and reportbug to file an RFS bug that
will also trigger mail to the list.

Cheers,
Nik

-- 
Wer den Grünkohl nicht ehrt, ist der Mettwurst nicht wert!

PGP-Fingerprint: 3C9D 54A4 7575 C026 FB17  FD26 B79A 3C16 A0C4 F296
diff -Naupr debian.old/control debian/control
--- debian.old/control	2013-09-28 22:21:53.000000000 +0200
+++ debian/control	2013-09-28 22:46:53.183763004 +0200
@@ -16,8 +16,7 @@ Vcs-Browser: https://github.com/chilicui
 
 Package: youtube-cli
 Architecture: all
-Depends: ${misc:Depends}, ${python:Depends}, mplayer2 | mplayer
-Recommends: youtube-dl
+Depends: ${misc:Depends}, ${python:Depends}, mplayer2 | mplayer, youtube-dl
 Description: command-line YouTube client
  yt is a command-line front-end to YouTube which allows you to browse YouTube
  videos and play them directly from the command-line. It uses youtube-dl and
diff -Naupr debian.old/README.source debian/README.source
--- debian.old/README.source	2013-09-28 22:21:53.000000000 +0200
+++ debian/README.source	2013-09-28 22:46:40.103599960 +0200
@@ -1,22 +1,19 @@
 Debian packaging for youtube-cli
 --------------------------------
 
-A quick summary of how one can update the Debian packaging of
-youtube-cli is:
+To get the source tarball, in the unpacked source package run:
 
-    git clone --dept=1 https://github.com/chilicuil/yt-deb
-    cd yt-deb
-    dch -i #insert proper new upstream version 
-    debian/rules get-orig-source
-    mv debian youtube-cli-*
-    cd youtube-cli-*
-    [ Make here some adaptations, like updating debian/patches, if needed ]
-    $EDITOR debian/changelog
-    debuild -S
-    upload .dsc | .changes files
-
-These are the important steps and may need to be changed according to
-deviations, say, in the release process of upstream releases (e.g., if
-upstream changes the location where the tarballs reside).
+ $ debian/rules get-orig-source
+
+This will leave the orig tarball in the current directory, you can
+move it to ../ and unpack it to create a basis for the new package
+version.
+
+If upstream  makes a new commit and you want to package it, run
+
+ $ dch -i
+
+and fill in the new upstream version in the changelog, then continue
+as described above.
 
  -- Javier P.L. <chilic...@ubuntu.com>, Sat 28 Sep 2013 11:04:54 PM CDT

Attachment: signature.asc
Description: Digital signature

Reply via email to