Package: libwww-mediawiki-client-perl
Version: 0.31-2+wuth4
Severity: normal
Tags: patch
Dear Maintainer,
Modern versions of mediawiki, such as 1.19.5-1, can not be configured
to not show the "this is a minor edit". "mvs -v commit" will choke on
these wikis reporting:
Doing commit Brett Wuth/Running_Notes/2013-10.wiki with host:
pccema.dnsalias.org and lang: en
wiki_path: mediawiki/
space_substitute: _
watch this page?: default
minor edit?: default
-----------------
Field 'minor_edit' cannot use OPT_DEFAULT: Default information could not be
determined.
Trace begun at /usr/share/perl5/WWW/Mediawiki/Client.pm line 1896
WWW::Mediawiki::Client::_option_check('WWW::Mediawiki::Client=HASH(0x8b16340)',
'minor_edit', -1, undef) called at /usr/share/perl5/WWW/Mediawiki/Client.pm
line 1823
WWW::Mediawiki::Client::_upload_file('WWW::Mediawiki::Client=HASH(0x8b16340)',
'Brett Wuth/Running_Notes/2013-10.wiki', 1) called at
/usr/share/perl5/WWW/Mediawiki/Client.pm line 1115
WWW::Mediawiki::Client::do_commit('WWW::Mediawiki::Client=HASH(0x8b16340)',
'Brett Wuth/Running_Notes/2013-10.wiki') called at /usr/bin/mvs line 92
eval {...} at /usr/bin/mvs line 92
main::main('commit', 'Brett Wuth/Running_Notes/2013-10.wiki') called at
/usr/bin/mvs line 228
A workaround is to use the command "mvs -v -M commit" instead.
The attached patch fixes the problem, allowing minor mode to be used
when permitted, and to be ignored (off) when not permitted.
-- System Information:
Debian Release: 7.1
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: i386 (i686)
Kernel: Linux 3.2.0-0.bpo.2-686-pae (SMP w/2 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages libwww-mediawiki-client-perl depends on:
ii libexception-class-perl 1.32-1
ii libvcs-lite-perl 0.09-1
ii libwww-perl 6.04-1
ii libxml-libxml-perl 2.0001+dfsg-1
ii perl 5.14.2-21
libwww-mediawiki-client-perl recommends no packages.
libwww-mediawiki-client-perl suggests no packages.
-- no debconf information
Index: libwww-mediawiki-client-perl-0.31/lib/WWW/Mediawiki/Client.pm
===================================================================
--- libwww-mediawiki-client-perl-0.31.orig/lib/WWW/Mediawiki/Client.pm 2013-10-07 22:36:27.000000000 -0600
+++ libwww-mediawiki-client-perl-0.31/lib/WWW/Mediawiki/Client.pm 2013-10-07 22:36:52.000000000 -0600
@@ -1677,7 +1677,9 @@
sub _get_edit_minor_default {
my ($self, $doc) = @_;
- return $self->_get_edit_checkbox($doc, EDIT_MINOR_NAME);
+ my $default = $self->_get_edit_checkbox($doc, EDIT_MINOR_NAME);
+ $default = OPT_NO unless defined($default);
+ return $default;
}
sub _check_path {
