Thanks for picking these up and apologies for letting them through. On Thu, Oct 10, 2013 at 08:05:18PM -0400, Luke Faraone wrote: > > Please document > ../doc/_themes/saltstack/static/css/bootstrap-responsive.css in > debian/copyright.
Will do. > > Please also recreate the minified versions during your package build, > don't just accept the ones generated by upstream. Will do. > > You do not ship the source for > ../doc/_themes/saltstack/static/js/vendor/modernizr-2.6.2-respond-1.1.0.min.js > at all, which is patently unacceptable. Agreed. Is it acceptable to add the source in via a quilt patch then build the minified version? or is there a better approach? > > This package embeds jQuery, which is suboptimal as jQuery is packaged in > Debian. Regardless, it must be mentioned in debian/copyright. > My understanding is that there are two approaches I could use here. I could rebuild the upstream .tar.gz without jQuery (and the others) or I could depend on the debian jQuery and patch the documentation to use the debian jQuery. If I do the second, we would still ship a (unused) version of jQuery in the orig.tar.gz, however, it would not be present in the .deb. As such, it should still be mentioned in the debian/copyright. Is this correct? I'm not thrilled by either option (upstream not including it/them would be best), but am leaning towards not modifying the orig.tar.gz as at this stage, I believe the contentious files are all (able to be) DFSG compliant. Thanks for your assistance. Joe -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
