Hi,

Vasudev Kamath wrote (19 Oct 2013 05:59:12 GMT) :
>> It seems to me that the attached patch symlinks
>> /usr/share/xmail/sample to /usr/share/doc/xmail/sample (while it
>> should do the contrary, right?) and does not move
>> /usr/share/doc/xmail/sample to /usr/share/xmail/sample.

> Regarding the symbolic linking excerpt from � 12.3

>>> Packages must not require the existence of any files in /usr/share/doc/
>>> in order to function 7 . Any files that are refer- enced by programs but
>>> are also useful as stand alone documentation should be installed under
>>> /usr/share/package/ with symbolic links from /usr/share/doc/package.

> So did I do something wrong in understanding above?

I believe you did it the wrong way.

>> Vasudev, did you actually test it with 'dpkg --path-exclude=...'?

> Regarding dpkg --path-exclude=... actually  I don't know how to execute
> this with piuparts as stated in bug report. I also encountered some
> other error with piuparts which I mentioned in the bug report reply.

I think you should install the patched package without piuparts, but
with dpkg --path-exclude=, see if it installs and configures fine,
look at the resulting symlinks, and see if it makes sense to you :)

(Or I am totally misunderstanding your path, which is possible too.)

>> Also, although a minor issue, unrelated whitespace changes are
>> generally not well suited for a NMU.

> Are you referring to new lines introduced by me or is there any
> whitespace in patch? I just did a white space cleanup on patch let me
> know if its fine.

The attached patch removes an empty line somewhere unrelated to
its purpose. That's what I call "unrelated changes".

Cheers,
-- 
  intrigeri
  | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
  | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to