On Sun, 06 Nov 2005, Duncan Findlay wrote: > On Sat, Nov 05, 2005 at 07:18:16PM -0800, Don Armstrong wrote: > > libnet-dns-perl is now required by M::SA::Dns > > If it's not installed, a warning message is issued, spamassassin > still runs. (If it's not, something wierd is happening -- it should > issue an error, but keep going.)
Hrm; it probably should actually have a dependency. That whole slath
of code in M::SA::Dns is rather craptacular though... it wraps the
requires in eval{} and then never checks their return values at all,
then blindly assumes that they succeded later on in the codebase. [The
only reason why this doesn't cause everything to explode is because
those places are wrapped in eval{} as well which only throw warnings.]
[line 83 onward of Mail::SpamAssassin::Dns]
eval {
require Net::DNS;
require Net::DNS::Resolver;
};
eval {
require MIME::Base64;
};
eval {
require IO::Socket::UNIX;
};
> > I'll make an NMU into the delayed queue sometime tomorrow to fix
> > this problem unless someone has some corrections to make to it.
>
> Please don't.
>
> I'll admit I'm a little short on time, and so I haven't
> appropriately responded to these reports but these are not bugs,
> strictly speaking.
Heh. That's why I talked about it before blindly NMUing; trying to
keep the RC bugs in perl related packages to sane levels if possible.
> The error messages even go away if you set "dns_available no" in
> /etc/spamassassin/local.cf and comment out "loadplugin
> Mail::SpamAssassin::Plugin::SPF" in /etc/spamassassin/init.pre
This should probably be the default then, with commentary in the
configuration files that you need to install these modules if you
uncomment those sections.
Don Armstrong
--
If you have the slightest bit of intellectual integrity you cannot
support the government. -- anonymous
http://www.donarmstrong.com http://rzlab.ucr.edu
signature.asc
Description: Digital signature
