On Fri, Nov 22, 2013 at 01:40:20AM +0400, Sergey B Kirpichev wrote:
> On Thu, Nov 21, 2013 at 10:06:59PM +0100, Andreas Tille wrote:
> > I checked out the git repository and have the following remarks:
> > 
> >   1. in d/README.source you wrote:
> >       ./07/tek2ps/ have been removed from sources
> > 
> >      It is OK to remove things from upstream source if needed but this
> >      should be turned into code rather than a document.
> > 
> >      The usual way to do so was adding a get-orig-source target into
> >      debian/rules.
> 
> Ok, done (grabbed from the nlopt package).

OK (not brave enough to try the new uscan which would have saved you
from this get-orig-source thingy by adding a single line to d/copyright?

> >   2. Any reason to choose debhelper compatibility level 7 instead of 9?
> 
> ok, done.

OK.

> >   3. To old Standards-Version
> 
> Now 3.9.5, it's ok?

Yep.  BTW, config model (see below) would have changed to 3.9.4
automatically but 3.9.5 is really the latest policy version (cme is
lagging behind a bit).

> >      I'd recommend using
> >          cme fix dpkg-control
> 
> What's that?
> 
> $ cme
> -bash: cme: command not found
> $ apt-cache search -n cme
> libacme-bleach-perl - Perl module for really clean programs
> libacme-brainfck-perl - Embed Brainf*ck in your perl code
> libacme-damn-perl - Perl module to unbless objects
> libacme-eyedrops-perl - funny way for visual programming in Perl
> libacme-poe-knee-perl - Time sliced pony race using the POE event loop
> procmeter3 - graphical system status monitor

Better search strategy:

  apt-file search /usr/bin/cme

Direkt hint:

  apt-get install libconfig-model-dpkg-perl libconfig-model-itself-perl
 
> >   4. d/copyright:  Please fix the issues occuring when doing
> >          cme fix dpkg-copyright
> 
> As above.

Ditto.
 
> >   5. I do not insist on fixing the vcs-field-not-canonical lintian info
> >      but I polished my own packages to fit his recommendation (you get
> >      it when calling `lintian -I`.
> 
> done.

Hope this helps

      Andreas.

-- 
http://fam-tille.de


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to