Hi,
Thanks for the bug report, and sorry for the trouble. I might not be
able to totally solve this bug for the next few weeks.
I am a little confused about some of these points, and I'll address each
individually, so here goes:
1.
>There is a syntax error line 26
> 26 $ TOP_LEVEL=""
>
> should be TOP_LEVEL=""
Oops, fixed. [1]
2.
> Line 42 if configure never ran then there is
> no makefile and make clean fails
I'm not clear about what DEP-8 wants here. DEP8 says
"The currently defined Features are:
no-build-needed The tests can run in an unbuilt tree."
This seems to reverse the build onus, as compared to what you say. This
sentence seems to imply that I have to use the no-build-needed feature
if i want to have an unbuilt tree. Otherwise a fully built tree should
be present - or am I misunderstanding? If you have some links to
relevant discussion about this, I don't suppose you can post them here?
Is this an ubuntu/debian difference?
Either way, Ive added a check for the existence of a valid Makefile,
which bypasses make clean as needed [1]. This doesn't solve the
dependency issue however - i've also add the appropriate Depends. IMHO
there is now duplication between control and the unit-tests control file :(.
>Alternatively all the configure/make bits of tests/unittest could be
>replaced
>by the restriction "build-needed" in autopkgtest's control file.
Unfortunately not. The build *must* occur during the unit test, as there
are different configure flags which enable different code paths - hence
the build at all.
In the debian/rules compilation (ie the deb package binaries), all
internal ASSERTions and TESTs are disabled with --disable-debug-checks.
Disabling these run-time checks makes the program noticeably faster
during many operations, and allows for more aggressive run-time checking
in debug mode.
Lastly, there are two versions of the code checked, single-threaded and
openmp multithreaded versions. The unit tests currently check both, as
either failing could be the result of an implementation error - in the
.deb file only the openmp enabled version is present.
4.
>And finally it seems the 3Depict -t needs a display to run
Yes, a display server is currently required. Here it works, as I am
running a display server. DEP8 doesn't seem to be clear on what a
minimal environment provides. I only tested this with adt-virt-null on
my local machine, and didn't even think about this.
Unfortunately, whilst the tests themselves theoretically don't need a
display, wx requires it, without some patching in program
initialisation. I will work on this for the next upload.
Just so you know (if you are filing en-masse?) unfortunately, your links
404/wont resolve (ubuntu-ci is not a valid hostname?) for me. but I
think your description is more than adequate to identify the issues in
this bug without a build log, so I don't specifically need it.
[1]
http://anonscm.debian.org/gitweb/?p=debian-science/packages/3depict.git;a=commitdiff;h=386f59a84c325e0f24047d1c4bf074cbe57ccc41
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
