Antoine Beaupré writes ("Bug#731632: dgit adds to quild gitignored files"):
> Package: dgit
> Version: 1.9
> Severity: normal
> 
> Running dgit git-build on my git checkout of bugs-everywhere commits a
> patch into quilt that include a file that is in .gitignore.

Hmmm.

I do think something is certainly at the very least not optimal here.
But I don't understand fully, so if you don't mind, I'll ask some
questions.

> The git repo:
>     git+ssh://git.debian.org/git/dgit-repos/repos/bugs-everywhere.git
> 
> The .gitignore:
...
> Actual result:
> the package quilt series has an extra entry for .be/id-cache.

Can you tell me where that ".be/id-cache" file comes from ?  (I've not
heard of this file before so you'll have to explain I'm afraid.)

Does your "debian/rules clean" delete it ?  (If the file was created
by the build process then I think it's a bug in the package if the
rules clean doesn't remove it again.  Of course one goal of dgit is to
make it convenient to work with bugyy packags - and in this case
that's what the -wg option is for: if you use that I think dgit will
delete the unwanted files, making your source tree properly clean.)

Did you expect there to be a quilt patch created by your upload ?
That is, were there changes in your git history which had not been
made into dpkg-source format `3.0 (quilt)' patches ?

The quilt patch is created by dgit running dpkg-source --commit.
But I think whether the creation of this file is recorded in a quilt
patch, or represented some other way in the source package (e.g., if
you had a format 1.0 native package, just in the tarball), isn't
really the point.  You probably didn't want it in the source package
at all.

Perhaps the bug is that dgit should have noticed that there were
changes to files which were .gitignored but not ignored by dpkg, and
complained.

I can see why you might think that (some or all of) the dgit build
functions should do the build in a fresh checkout.  But this is
awkward because dgit doesn't know which of the files in the parent
directory are necessary to produce the correct .dsc.

Thanks,
Ian.


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to