Source: ocl-icd
Version: 2.1.0
Severity: normal
Tags: patch

I spent a while trying to build the unstable version on unstable, discovering 
the AM_PROG_AR bug 713333 and then the
test bug 700398, before realising that there was a newer version that already 
fixed all this in experimental.

During that process I discovered that this package will only ever build once 
after unpacking. Because it does an autoreconf, 
and thus a load of autotools files get overwritten with new verions, and it is 
a dpkg quilt-format package: dpkg 
fails on the second build, pointing out the huge patch of changed source files.

This is very simply fixed by the attached patch which uses dh-autoreconf, 
instead of the dh_autotools-dev that 
was already in use, to track all the changed autotools files, and not just 
config.sub/guess, so that the source 
can be restored to its pristine state in the clean rule.

This works nicely.

Rebuildability is important, especially for porters, and in this case is very 
easy to preserve. Please include 
this in the next upload. (Can the experimental version be uploaded to unstable 
now BTW - that would be very helpful?)

-- System Information:
Debian Release: 7.3
  APT prefers stable
  APT policy: (990, 'stable')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-kvm-i386-20110111 (SMP w/1 CPU core)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
diff -Nru ocl-icd-2.1.0/debian/changelog ocl-icd-2.1.0/debian/changelog
--- ocl-icd-2.1.0/debian/changelog	2013-10-02 14:25:10.000000000 +0000
+++ ocl-icd-2.1.0/debian/changelog	2013-12-22 03:24:45.000000000 +0000
@@ -1,3 +1,9 @@
+ocl-icd (2.1.0-1arm64) unstable; urgency=low
+
+  * Use dh-autoreconf so package is rebuildable
+
+ --  <wookey@wookware.org2>  Sun, 22 Dec 2013 03:23:36 +0000
+
 ocl-icd (2.1.0-1) experimental; urgency=low
 
   * New upstream release
diff -Nru ocl-icd-2.1.0/debian/control ocl-icd-2.1.0/debian/control
--- ocl-icd-2.1.0/debian/control	2013-10-02 14:25:10.000000000 +0000
+++ ocl-icd-2.1.0/debian/control	2013-12-22 03:22:18.000000000 +0000
@@ -2,7 +2,7 @@
 Priority: extra
 Maintainer: Vincent Danjean <vdanj...@debian.org>
 Build-Depends: debhelper (>= 9.0.0), opencl-headers (>= 1.2), ruby,
- autotools-dev (>=20100122.1~),
+ dh-autoreconf,
  autoconf (>=2.68), automake (>=1:1.10), libtool,
  asciidoc, xmlto
 Standards-Version: 3.9.4
diff -Nru ocl-icd-2.1.0/debian/rules ocl-icd-2.1.0/debian/rules
--- ocl-icd-2.1.0/debian/rules	2013-10-02 14:25:10.000000000 +0000
+++ ocl-icd-2.1.0/debian/rules	2013-12-22 03:22:09.000000000 +0000
@@ -10,7 +10,7 @@
 #export DH_VERBOSE=1
 
 %:
-	dh $@ --parallel --with autotools_dev
+	dh $@ --parallel --with autoreconf
 
 .PHONY: override_dh_auto_configure
 override_dh_auto_configure:

Reply via email to