Package: slrn
Version: 1.0.1-8
Severity: important
Tags: patch
User: base-pas...@packages.debian.org
Usertags: shell-fallout

In base-passwd 3.5.30, I changed the news user's shell to
/usr/sbin/nologin (a change that I really should have made about ten
years ago).  This has unfortunately had a bit of collateral damage: slrn
tries to use "su news" in various places without overriding the shell.
Here's a fix:

  * Pass "-s /bin/sh" to "su news" to cope with the change of the news
    user's shell in base-passwd 3.5.30.

diff -Nru slrn-1.0.1/debian/slrn_getdescs slrn-1.0.1/debian/slrn_getdescs
--- slrn-1.0.1/debian/slrn_getdescs     2013-12-16 16:37:05.000000000 +0000
+++ slrn-1.0.1/debian/slrn_getdescs     2014-01-09 12:14:17.000000000 +0000
@@ -22,6 +22,6 @@
 if (! -f $dsc_file || -M $dsc_file >= $min_age) {
        $dsc_file_slrn=$dsc_file;
        $dsc_file_slrn=~s/\.dsc$//; # slrn doesn't want the extention.
-       system "su news -c 'slrn -i $global_rc_file -f $dsc_file_slrn -h \$(cat 
/etc/news/server) -d'";
+       system "su news -s /bin/sh -c 'slrn -i $global_rc_file -f 
$dsc_file_slrn -h \$(cat /etc/news/server) -d'";
        chmod 0644,$dsc_file;
 }
diff -Nru slrn-1.0.1/debian/slrnpull.cron.daily 
slrn-1.0.1/debian/slrnpull.cron.daily
--- slrn-1.0.1/debian/slrnpull.cron.daily       2013-12-16 16:37:05.000000000 
+0000
+++ slrn-1.0.1/debian/slrnpull.cron.daily       2014-01-09 12:13:58.000000000 
+0000
@@ -12,7 +12,7 @@
 cd /var/spool/slrnpull
 
 # Perform expiration, even if we aren't fetching articles right now.
-su news -c 'slrnpull --expire >/dev/null'
+su news -s /bin/sh -c 'slrnpull --expire >/dev/null'
 
 if  [ "$RUNFROM" = "cron job" ] ; then
        # Get new articles.
diff -Nru slrn-1.0.1/debian/slrnpull.if-up slrn-1.0.1/debian/slrnpull.if-up
--- slrn-1.0.1/debian/slrnpull.if-up    2013-12-16 16:37:05.000000000 +0000
+++ slrn-1.0.1/debian/slrnpull.if-up    2014-01-09 12:14:10.000000000 +0000
@@ -15,5 +15,5 @@
 
 if [ "$RUNFROM" = "ip-up" -a "$METHOD" != loopback ] ; then
        # Get new articles.
-       su news -c 'slrnpull -h `head -n 1 /etc/news/server` >/dev/null'
+       su news -s /bin/sh -c 'slrnpull -h `head -n 1 /etc/news/server` 
>/dev/null'
 fi
diff -Nru slrn-1.0.1/debian/slrnpull.ppp.ip-up 
slrn-1.0.1/debian/slrnpull.ppp.ip-up
--- slrn-1.0.1/debian/slrnpull.ppp.ip-up        2013-12-23 19:49:39.000000000 
+0000
+++ slrn-1.0.1/debian/slrnpull.ppp.ip-up        2014-01-09 12:14:02.000000000 
+0000
@@ -15,5 +15,5 @@
 
 if [ "$RUNFROM" = "ip-up" -a "$METHOD" != loopback ] ; then
        # Get new articles.
-       su news -c 'slrnpull -h `head -n 1 /etc/news/server` >/dev/null'
+       su news -s /bin/sh -c 'slrnpull -h `head -n 1 /etc/news/server` 
>/dev/null'
 fi

Sorry,

-- 
Colin Watson                                       [cjwat...@debian.org]


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to