Vasudev Kamath <kamathvasu...@gmail.com> writes: > IOhannes m zmölnig <zmoel...@iem.at> writes: > > Hi IOhannes, > >> On 2013-10-10 17:19, Jonas Smedegaard wrote: >>> Great approach! >>> >>> I've wanted to deal with this for some time but wanted and approach that >>> was backporting-friendly, which this could be. >>> >>> I am pretty bogged down currently - will you try implement it? >> >> attached is an attempt. >> i don't dare to push that directly to cdbs-git. > > I just checked the patch but I'm not clear how this new feature should > be used commit message says semicolon but eg shows usage of comma > instead. I installed the patched version and did following > > DEB_AUTO_UPDATE_AUTOMAKE = ,12 > > I was expecting it to generate automake (>= 1:1.12) but instead > generated version was automake (<= 12) which seems to me as wrong > because there is no such version in archive.
I totally misunderstood your comments now after toying around a bit I'm able to get it working. But I still see following problem. - If we have both DEB_AUTO_UPDATE_ACLOCAL and DEB_AUTO_UPDATE_AUTOMAKE set we will end up getting to automake dependency. As an example I did following DEB_AUTO_UPDATE_ACLOCAL = 1.14, DEB_AUTO_UPDATE_AUTOMAKE = 1.14, after regenerating control file I've 2 automake (>= 1.14) in Build-Depends field. I also noted the code remains same as previous with slight modification but previously this duplication was not happening but now its happening and I'm not sure why :( I also noted if I remove , in above expression cdbs generates dependency as automake1.14 but I guess this name is no longer valid and should be handled appropriately - Normally when we provide new feature in CDBS and user uses it we bump the cdbs version to be >= new_version~ where new_version is the version where feature was introduced. This needs to be done for this feature. I'm planning to push the branch where I've applied your patch so we can collaborate and get this fixed afterwards Jonas and other CDBS hackers can check this and merge it with master. Are you okay with this? Warm Regards -- Vasudev Kamath http://copyninja.info Connect on ~friendica: copyninja@{frndk.de | vasudev.homelinux.net} IRC nick: copyninja | vasudev {irc.oftc.net | irc.freenode.net} GPG Key: C517 C25D E408 759D 98A4 C96B 6C8F 74AE 8770 0B7E
signature.asc
Description: PGP signature