On Wed, Feb 5, 2014 at 6:57 AM, Arturo Borrero Gonzalez wrote: > rpmlint - RPM package checker
How you intend to use this package - what is your motivation for wanting this in Debian? A review: The blank line and comment in debian/watch are not needed. Why did is the test suite disabled in debian/rules? Please send the manual page for rpmdiff upstream. The README.devel file is not needed in the binary package. The copyright file is missing a stanza for debian/* and for some upstream copyright holders. Please remove __version__.py and __isocodes__.py in `debian/rules build` to ensure they can be recreated at build time. The upstream Makefile installs rpmdiff to /usr instead of /usr/local when you build from source. Please ask upstream to support installing to an arbitrary prefix and default to /usr/local (the Debian packaging would then override that to /usr). Automated checks: https://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package lintian: P: rpmlint source: debian-watch-may-check-gpg-signature pep8: Lots of warnings. fixme/todo/hack: ./test/test.PamCheck.py:# FIXME harcode ./BinariesCheck.py: # FIXME this check is too slow, because forking for objdump is quite slow ./Pkg.py: # TODO: magic.MAGIC_COMPRESS when PkgFile gets decompress support. ./Pkg.py: # TODO: better shell escaping or sequence based command invocation ./Pkg.py: # TODO: decompression support ./PostCheck.py: # TODO: test that "prog" is available/executable ./FilesCheck.py:filesys_packages = ['filesystem'] # TODO: make configurable? ./FilesCheck.py: # TODO, better handling for these (see e.g. Lintian) ./FilesCheck.py: # TODO: better shell escaping or seq based invocation ./FilesCheck.py: # ignore perl module shebang -- TODO: disputed... ./TagsCheck.py: # TODO: should take versions, <, <=, =, >=, > into account here ./I18NCheck.py: # TODO: @Foo and charset handling ./I18NCheck.py: # TODO: don't accept all lang_COUNTRY combinations ./InitScriptCheck.py: # TODO check if there is only one line like this ./InitScriptCheck.py: # TODO maybe we do not have to handle this ? ./rpmdiff: # filter self provides, TODO: self %name(%_isa) as well ./SpecCheck.py:# TODO: better handling of X libraries and modules. ./SpecCheck.py: # TODO: check scriptlets for these too? ./Pkg.py: # Blows up with Python < 3 without the exec() hack ./Pkg.py: # (yes, this is an ugly hack and we probably have other problems with ./FilesCheck.py: # Hack: basenames with empty paths links are symlinks (not subject ./SpecCheck.py: # Hack to get the correct (start of ./configure) line ./SpecCheck.py: # No such file or dir hack: https://bugzilla.redhat.com/487855 -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org