On 02/05/2014 11:44 AM, László Böszörményi (GCS) wrote:
> On Tue, Feb 4, 2014 at 2:09 PM, Michael Haggerty <mhag...@alum.mit.edu> wrote:
>> On 02/04/2014 01:44 PM, László Böszörményi (GCS) wrote:
>>> On Mon, Feb 3, 2014 at 1:56 PM, Michael Haggerty <mhag...@alum.mit.edu>
>>> wrote:
>>>> On 01/30/2014 05:01 PM, Stephen Oberholtzer wrote:
>>>>> Attached is a patch that corrects this problem, so that the package
>>>>> builds.
>>> Maybe an other thing changed since then, but last time I tried your
>>> patch cvs2svn self-tests still failed.
> Just tried again. Version 2.4.0 with the patch applied still fails with:
> -- cut --
> PASS: run-tests.py 3: generate a manpage for cvs2git
> SKIP: run-tests.py 4: generate a manpage for cvs2hg
> unexpected log output (missing changed paths)
> Line: '
> '
> EXCEPTION: SystemExit(1), skipping cleanup
> FAIL: run-tests.py 5: detection of the executable flag
> -- cut --
> Installed versions:
> Subversion is 1.8.5
> CVS is 1.12.13+real-11
> rcs is 5.9.2
> python is 2.7.6
>
>> There's not a lot of activity in the project so it is relatively
>> arbitrary when to make a release. But if you don't need one then I'll
>> gratefully spare myself the effort :-)
> May you check what can be the problem in the above mentioned configuration?
This test works for me.
My guess is that either the package itself or the test's temporary files
are on a filesystem that does not allow the executable bit to be set.
The whole point of the test is to check that the executable bit is being
set on the file after the conversion, based on the executable bit being
set on test-data/main-cvsrepos/single-files/attr-exec,v in the test data
input. So if indeed the Debian test infrastructure does not allow the
executable bit to be set, the only alternative would be to skip this
test on your setup. If the limitation is on the input then something
like this should do the trick:
diff --git a/run-tests.py b/run-tests.py
index edf7bbd..7322fd6 100755
--- a/run-tests.py
+++ b/run-tests.py
@@ -969,6 +969,11 @@ def attr_exec():
"detection of the executable flag"
if sys.platform == 'win32':
raise svntest.Skip()
+ st = os.stat(os.path.join('test-data', 'main-cvsrepos',
'single-files', 'attr-exec,v'))
+ if not st.st_mode & stat.S_IXUSR:
+ # This might be the case if the test is being run on a filesystem
+ # that is mounted "noexec".
+ raise svntest.Skip()
conv = ensure_conversion('main')
st = os.stat(conv.get_wc('trunk', 'single-files', 'attr-exec'))
if not st.st_mode & stat.S_IXUSR:
If the limitation is on the output directory, then we would probably
have to try setting the executable bit on some file to see if it is allowed.
Michael
--
Michael Haggerty
mhag...@alum.mit.edu
http://softwareswirl.blogspot.com/
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
