Package: dh-make
Version: 0.40
Severity: minor
Adding -Wl,-z,defs to CFLAGS causes gcc (at least 3.3.5) to
produce warnings of the form
gcc: -z: linker input file unused because linking not done
gcc: defs: linker input file unused because linking not done
The following patch adds it to LDFLAGS instead, so that it
is only used when the linker is called. The patch also
moves CFLAGS and LDFLAGS to the arguments of the ./configure
call making it more readable. (and it is the place configure --help
suggest for those)
diff -u -r dh-make-0.40.orig/dh_make dh-make-0.40/dh_make
--- dh-make-0.40.orig/dh_make 2005-08-26 03:54:42.000000000 +0200
+++ dh-make-0.40/dh_make 2005-11-14 11:09:17.000000000 +0100
@@ -462,7 +462,7 @@
$CONFIGURE="config.status: configure\n".
"\tdh_testdir\n".
"\t# Add here commands to configure the package.\n".
- "\t".'CFLAGS="$(CFLAGS) -Wl,-z,defs" ./configure
--host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) --prefix=/usr
--mandir=\$${prefix}/share/man --infodir=\$${prefix}/share/info'."\n";
+ "\t".'./configure --host=$(DEB_HOST_GNU_TYPE)
--build=$(DEB_BUILD_GNU_TYPE) --prefix=/usr --mandir=\$${prefix}/share/man
--infodir=\$${prefix}/share/info CFLAGS="$(CFLAGS)" LDFLAGS="-Wl,-z,defs"'."\n";
$DPKG_ARCH="# These are used for cross-compiling and for saving the
configure script\n".
"# from having to guess our platform (since we know it
already)\n".
'DEB_HOST_GNU_TYPE ?= $(shell dpkg-architecture
-qDEB_HOST_GNU_TYPE)'."\n".
Hochachtungsvoll,
Bernhard R. Link
diff -u -r dh-make-0.40.orig/dh_make dh-make-0.40/dh_make
--- dh-make-0.40.orig/dh_make 2005-08-26 03:54:42.000000000 +0200
+++ dh-make-0.40/dh_make 2005-11-14 11:09:17.000000000 +0100
@@ -462,7 +462,7 @@
$CONFIGURE="config.status: configure\n".
"\tdh_testdir\n".
"\t# Add here commands to configure the package.\n".
- "\t".'CFLAGS="$(CFLAGS) -Wl,-z,defs" ./configure
--host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) --prefix=/usr
--mandir=\$${prefix}/share/man --infodir=\$${prefix}/share/info'."\n";
+ "\t".'./configure --host=$(DEB_HOST_GNU_TYPE)
--build=$(DEB_BUILD_GNU_TYPE) --prefix=/usr --mandir=\$${prefix}/share/man
--infodir=\$${prefix}/share/info CFLAGS="$(CFLAGS)" LDFLAGS="-Wl,-z,defs"'."\n";
$DPKG_ARCH="# These are used for cross-compiling and for saving the
configure script\n".
"# from having to guess our platform (since we know it
already)\n".
'DEB_HOST_GNU_TYPE ?= $(shell dpkg-architecture
-qDEB_HOST_GNU_TYPE)'."\n".
