Hi Adam, On Sun, Feb 23, 2014 at 06:10:42PM -0700, Adam Conrad wrote: > * link-atomic.patch: Switch from __sync to __atomic to support more arches. > * Switch back to arch:any instead of the Debian maintainer's shorter list. > > So, this patch should be almost upstreamable, depending on who their > intended target is. If they need to support __sync on non-Linux, > they could wrap __sync and __atomic blocks in ifdef/ifndef magic to > test for linux or perhaps specific GCC versions.
Thanks for the patch. I had suggested the same and discussed it with Magnus (upstream) too among other options[1], but the __atomic functions are GCC 4.7+, which would break builds with e.g. precise and are hence unattractive for upstream inclusion. Magnus has on his plans to rethink atomic operations and independently of that switch to autoconf, so we could perhaps make this more reasonable than a bunch of #ifdefs that would break with weird error messages under certain combinations of GCC version/architecture :) I'll poke him again. Thanks for your bug report. Faidon 1: Another one would be limiting the queue size to 4GB on 32-bit architectures (i.e. switch from uint64_t to long), which wouldn't be such a big deal considering librdkafka's use cases. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
