Package: git
Version: 1:1.9.0-1
Severity: normal
File: /usr/share/gitweb/static/gitweb.js
Tags: upstream


The gitweb.js contains fixLinks() function which gets enabled when
 $feature{'javascript-actions'}{'default'} = 1
is set in gitweb.conf. 

The function happily adds '#js=1' or '?js=1' to all the links generated 
by gitweb, including external links that might be added by local user 
in README.html files or via feature{'actions'}{'default'} in gitweb.conf.

Obviously those modified external links may no longer work, especially
when they point to some CGI script that validates passed parameters or 
for any reason modifies its behaviour when 'js' parameter is given.

Please fix this issue by modifing fixLinks() to change only the internal
gitweb.cgi links or - preferably - by dropping the fixLinks() function
and handling $feature{'javascript-actions'} properly in gitweb.cgi
itself.

Regards,
robert


-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (200, 'testing')
Architecture: i386 (i686)

Kernel: Linux 3.11-2-686-pae (SMP w/1 CPU core)
Locale: LANG=pl_PL.UTF8, LC_CTYPE=pl_PL.UTF8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages git depends on:
ii  git-man          1:1.9.0-1
ii  libc6            2.18-4
ii  libcurl3-gnutls  7.35.0-1
ii  liberror-perl    0.17-1.1
ii  libexpat1        2.1.0-4
ii  libpcre3         1:8.31-2
ii  perl-modules     5.18.2-2
ii  zlib1g           1:1.2.8.dfsg-1

Versions of packages git recommends:
ii  less                         458-2
ii  openssh-client [ssh-client]  1:6.5p1-6
ii  patch                        2.7.1-4
ii  rsync                        3.1.0-2

Versions of packages git suggests:
ii  gettext-base                          0.18.3.2-1
pn  git-arch                              <none>
pn  git-bzr                               <none>
pn  git-cvs                               <none>
pn  git-daemon-run | git-daemon-sysvinit  <none>
ii  git-doc                               1:1.9.0-1
pn  git-el                                <none>
ii  git-email                             1:1.9.0-1
ii  git-gui                               1:1.9.0-1
pn  git-mediawiki                         <none>
ii  git-svn                               1:1.9.0-1
ii  gitk                                  1:1.9.0-1
ii  gitweb                                1:1.9.0-1

-- no debconf information

-- debsums errors found:
debsums: changed file /usr/share/gitweb/static/gitweb.js (from git package)


-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to