Hi Markus, On Tue, Mar 25, 2014 at 04:04:15PM +0100, Markus Koschany wrote: > Hi Ricardo, > > On 25.03.2014 15:32, Ricardo Mones wrote: > [...] > > It's simpler to add the png icons to packaging directory. They're not > > going to change anytime soon. Adding a dependency and converting on every > > build is an unnecesary waste of network and cpu time. > > It depends on the maintainer. :) Other maintainers had requested the > exact opposite in the past and they prefer to build everything from > source. It's completely up to you if you want to add the icons to your > debian directory or if you want to build them from source. Since I can't > foresee what kind of solution the maintainer prefers, I provide a patch > for the "more complex" and time-consuming solution.
Indeed, but you can also ask before consuming time :-) I wasn't even aware you had intentions to submit a patch (which is very appreciated). > Many games are accompanied by a data package which is arch:all. I > usually use dh_auto_build-indep to build the icons and install them in > the arch-independent package. In case of oneko that was not possible. > > Also please note that your package only ships xbm files which are not > supported by desktop files, so I had to convert your icons to the xpm > file format hence these icons can be used with Debian's menu files as > well as with desktop files. Yes, I'm aware of that, the plan is to convert them to PNG, which I think has better transparency support than XPM (and is more compact). > [...] > > And what does happen on non-GNOME3 desktops? > > Also, are GNOME3 users supposed to already know that info? > > My patch makes oneko visible on all desktops. So KDE, Xfce or LXDE users > will see exactly the same as GNOME3 users thanks to the new > oneko.desktop file. Users of Debian's menu will now see icons in > addition to their usual menu entries too. > > The Action entries are just a "bonbon" for all those users who have the > corresponding extensions installed. Users of Gnome3 should be aware of > > https://packages.debian.org/sid/gnome-shell-extensions > > and > > https://extensions.gnome.org/# > > KDE supports this standard by default. You don't have to install further > extensions here. Allright, questions were just to be sure nothing needs to be added to oneko README.Debian file :) Thanks for the detailed explanations, -- Ricardo Mones ~ Absence of evidence is not evidence of absence. Carl Sagan
signature.asc
Description: Digital signature
