Hi Cristian,

On Sun, Oct 30, 2005 at 02:16:01AM +0100, Cristian Ionescu-Idbohrn wrote:
>   * Added option '-t' (time stamp); socklog.c modified.

What is this for?  The timestamp normally is added by the logger
process, usually the svlogd program.  Can you tell me a use case where
this is needed?

>   * killed some compilation warnings in socklog.c, chkshsgr.c, seek_set.c;
>     some more left in pathexec_run.c, pathexec.h, prot.c.

I don't want to change this.  The code and compilation is tested on many
Unix systems, not only Linux, and was proven to be very portable the way
it is.

>   * debian/rules applies patches.

I usually use a construct like this:

        for i in `ls -t debian/diff/*.diff || :`; do \
          (cd admin/socklog && patch -p0) <$$i || exit 1; \
        done

You then simply put patches into debian/diff/ with a .diff extension.
But I don't think we need that for socklog, as I'm upstream too, and the
project is quite mature and stable.

>   * debian/rules builds with debug too.

I'll apply this.

Thanks for your suggestions and feedback.  Regards, Gerrit.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to