Hi, Thomas.

Thanks for your advice.
I fixed and uploaded to mentors.d.n.

Would you upload this package?
http://mentors.debian.net/debian/pool/main/p/pystache/pystache_0.5.3-3.dsc

Best regards,
--
Kouhei Maeda <mkouhei at {palmtb.net,debian.or.jp}>
 KeyID 4096R/7E37CE41


2014-03-18 0:45 GMT+09:00 Thomas Goirand <z...@debian.org>:
> Hi Kouhei,
>
> I've notice that it's been a long time that pystache has RC bugs. The
> issue on the package is that you are calling "2to3 -w --no-diffs build3"
> in override_dh_auto_build:, but setup.py is already doing it, so you are
> doing it twice, which is breaking some unicode strings.
>
> This let me wonder if the 2to3 call in override_dh_auto_install: is
> necessary, probably it also break stuff.
>
> Also, I've noticed some problems in your package. First, you shouldn't set:
> X-Python-Version: 2.7, >= 3.3
>
> Yes, we don't have python 3.2 in Sid/Testing, but the package is still
> compatible with Python 3.2, as per the declaration in setup.py.
> Therefore, by setting-up X-Python-Version: 2.7, you are preventing the
> package from being back-ported correctly in Wheezy. Also,
> X-Python-Version: >= 3.3 has no effect: it's X-Python3-Version that you
> should have used to limit Python 3 versions.
>
> Last, there's no need to add "&& \" on each lines of your debian/rules.
> The build will stop on the first error anyway.
>
> Please fix the above. If you need sponsoring for the upload of the fixed
> package, please let me know, and I will upload for you.
>
> If you can't do the work, please let me know, and I will NMU the package.
>
> Cheers,
>
> Thomas Goirand (zigo)


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to