Bug#748401: Missing HAVE_DBUS causing type conflict

[Mike Gabriel]

Hi Michael,

On  Fr 16 Mai 2014 23:47:42 CEST, Michael Tautschnig wrote:

Package: eom
Version: 1.8.0+dfsg1-1
Usertags: goto-cc


reporting on type inconsistencies at link time.

[...]


error: conflicting function declarations "eom_application_get_instance"
old definition in module main file eom-application.h line 69
struct _EomApplication * (void)
new definition in module eom file ../../src/eom-application.h line 69
struct _EomApplication * (void)

reason for conflict in types listed below (struct/struct):
composite type component counts differ (4/3)
struct _EomApplication {
  struct _GObject base_instance;
  struct EggToolbarsModel * toolbars_model;
  char * toolbars_file;
  struct TotemScrsaver * scr_saver;
}
struct _EomApplication {
  struct _GObject base_instance;
  struct EggToolbarsModel * toolbars_model;
  char * toolbars_file;
}
make[4]: *** [eom] Error 64

make[3]: *** [all] Error 2

Reviewing the---almost---shared declaration:

http://sources.debian.net/src/eom/1.8.0%2Bdfsg1-2/src/eom-application.h?hl=58,59,60#L53

it seems that a #define HAVE_DBUS must be missing from the file that was
compiled as eom, which likely is

http://sources.debian.net/src/eom/1.8.0%2Bdfsg1-2/bindings/python/eom.override

That file might just be in need of #include "config.h" to ensure consistency.

Best,
Michael

During a rebuild of all packages in a clean sid chroot (and cowbuilder+pbuilder) the build failed with the following error. Please note that we use our research compiler tool-chain (using tools from the cbmc package), which permits extended libtool: link: gcc -I../cut-n-paste/toolbar-editor -I../cut-n-paste/totem-screensaver -pthread -I/usr/include/mate-desktop-2.0 -I/usr/include/dconf -I/usr/include/startup-notification-1.0 -I/usr/include/gtk-2.0 -I/usr/include/gtk-unix-print-2.0 -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/libpng12 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng12 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/libexif -I/usr/include/exempi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -DEOM_DATA_DIR=\"/usr/share/eom\" -DEOM_LOCALE_DIR=\"/usr/share/locale\" -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall -Wl,-z -Wl,relro -o eom eom-main.o -Wl,--export-dynamic -pthread -pthread -Wl,--export-dynamic ./.libs/libeom.a -L/usr/lib/python2.7/config -lpython2.7 -lgmodule-2.0 -lgthread-2.0 -lmate-desktop-2 -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 /usr/lib/x86_64-linux-gnu/libcairo.so -lgdk_pixbuf-2.0 -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lfontconfig /usr/lib/x86_64-linux-gnu/libfreetype.so -lexif -lexempi -ldbus-glib-1 -ldbus-1 -lgobject-2.0 -lglib-2.0 /usr/lib/x86_64-linux-gnu/libjpeg.so ../cut-n-paste/toolbar-editor/.libs/libtoolbareditor.a -lxml2 ../cut-n-paste/totem-screensaver/.libs/libtotemscrsaver.a -lX11 ../jpegutils/.libs/libeom-jpegutils.a -lm -lz -pthread make[4]: Leaving directory `/srv/jenkins-slave/workspace/sid-goto-cc-eom/eom-1.8.0+dfsg1/src'

Greets,
Mike
--

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

thanks for providing this extra info and thanks for doing those package rebuilds for constant QA integrity. Can you please point me to a howto that explains how to reproduce those build failures here locally? It would be good to do a reference build here before re-uploading a package that still has the same flaw.

pgpk1NGLZWvJa.pgp
Description: Digitale PGP-Signatur