On Tue, 24 Jun 2014 at 21:46:24 +0100, Simon McVittie wrote: > As Lukas Anzinger pointed out in #751275, his patch applied in 0.9.0 causes > plymouth to regress to text mode on DRM drivers. I think it would be better > to revert that patch.
On Wed, 25 Jun 2014 at 00:57:31 +0200, Daniel Baumann wrote: > close 752575 0.9.0-3 Thanks for applying that change. To avoid bugs similar to this happening again, I think it's worth pointing out that you might have misunderstood copy_modules_dir's syntax: the description of those changes in debian/changelog is reversed. The second and subsequent arguments to copy_modules_dir are directories or modules to *exclude*, so Lukas' patch *removed* drm from the initramfs (despite being documented as adding it), and my reversion of that patch added it back (which was correct in the commit message I sent, but is described as removing it in the debian/changelog that you uploaded). Sorry if I wasn't clear about this before. Additionally, the arguments to copy_modules_dir are passed to find(1) in the form "find ... -name drm -prune -o ...", so "copy_modules_dir kernel/drivers/gpu/drm drm" means "copy everything from kernel/drivers/gpu/drm, but exclude directories named drm", which is why it resulted in nothing being copied into the initramfs at all. If you want to exclude individual modules, without excluding entire directories, the way to do that seems to be "copy_modules_dir ... drm.ko" (but please don't do that, because i915.ko, radeon.ko etc. depend on drm.ko, so that would reintroduce #752575). I suspect the best solution for uvesafb/fglrx users like Lukas might be to blacklist drm.ko so it is never loaded. Perhaps fglrx should ship /etc/modprobe.d/fglrx-blacklist.conf containing "blacklist drm", "blacklist radeon"? I'm not sure whether that would break dual-graphics-card machines, though: I've only heard of machines that combine nVidia discrete graphics and Intel integrated graphics, but similar AMD/Intel combinations might also exist. S -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org