On 25/06/14 00:05, Samuel Bronson wrote:
> Yeah, I *did* notice that my changes won't just magically make things
> better for dbus; it would, in fact, require patching configure.ac there
> as well. However, what little mention I see of the pkg-config file on
> valgrind's bug tracker is skeptical about it's usefulness as well; my
> proposal certainly isn't making things any worse.
I would not oppose changing dbus' configure.ac to use AC_CHECK_HEADER,
and changing dbus to include <valgrind/valgrind.h>, if that's what it
takes. I am an upstream D-Bus maintainer, so as long as I can coerce one
of my upstream co-maintainers into reviewing my change, patching
configure.ac is not a problem.
I slightly prefer pkg-config because that provides a standard way to set
non-standard paths, even if you don't even have pkg-config (FOO_CFLAGS
and FOO_LIBS will override the configure check for FOO), but if valgrind
upstream intend valgrind.pc to be for external tools and don't want to
provide a valgrind-client-requests.pc, that's fair enough.
>> A real solution would really be to have Debian packages stop
>> Build-Depending on valgrind in the first place.
>
> Actually, for libraries, such facilities can also be important to any
> developers using those libraries in other software; if, for example, not
> enabling valgrind client requests at build time will result in valgrind
> reporting false errors in any program that uses that library, that could
> get majorly annoying to people developing against the distro version of
> that library.
Yes, this is why libdbus uses valgrind instrumentation: it has a
memory-pool mechanism to recycle small memory allocations (mainly
linked-list links), so valgrind will report significant memory leaks
unless libdbus uses client requests to teach valgrind about what it's doing.
In the Debian package, the instrumentation is only present in the "debug
build" (install dbus-1-dbg and add
/usr/lib/x86_64-linux-gnu/dbus-1.0/debug-build/lib to the
LD_LIBRARY_PATH), not in the build that is normally used by the OS.
S
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
