Tobias Frost writes: > Hi Steven, > > Please note, I can only review, but I cannot sponsor as my NM process is > not yet finished... > > On Sun, 2014-06-29 at 20:30 +1000, Steven Hamilton wrote: >> Package: sponsorship-requests >> Severity: normal >> >> Dear mentors, >> >> I am looking for a sponsor for my package "mrrescue" >> >> * Package name : mrrescue >> Version : 1.02c-1 >> Upstream Author : [fill in name and email of upstream] >> * URL : http://www.tangramgames.com > > It should be http://tangramgames.dk/games/mrrescue/, shouldn't it? > Yes, It's correct in the control file
>> * License : zlib, MIT, BY-SA 3.0 >> Section : games >> >> It builds those binary packages: >> >> mrrescue - Mr Rescue is an arcade 2d action game >> >> To access further information about this package, please visit the >> following URL: >> >> http://mentors.debian.net/package/mrrescue >> >> >> Alternatively, one can download the package with dget using this command: >> >> dget -x >> http://mentors.debian.net/debian/pool/main/m/mrrescue/mrrescue_1.02c-1.dsc >> >> More information about hello can be obtained from http://www.example.com. >> > > - d/copyright: > > * Please adapt to the machine-readable format; You're already close, but > at least some headers are missing: > https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ > * License texts are missing > * Filenames are wrong: There is no mrresuce.love directory > in the source. > * Also, please also use the same spelling for the licenses: ZLIB/zlib > (Sugessted is to use the abbreviations as in http://spdx.org/licenses/) > * s/BY-SA 3.0/CC-BY-SA-3.0 All fixed up. A license texts included. > * d/docs > README.txt ist not required to be installed, the information within are > not needed on a Debian system > Removed > * d/mrrescue > Is there are resson to use /bin/bash as shebang and not use /bin/sh? > (then you would also need to depend on bash; but its not necessary to > have bash, right?) Changed to /bin/sh > > * d/mrrsecue.1 > It's great that you provide a manpage. IMHO writing manpages is one of > the most tedious work to be done during packaging ... You should also > forward it upstream, (when its ready :) > However, I think it need a little overhaul. Please read man-pages(7) and > man(7) > - Shouldn't it be section 6, games? > - in the NAME Section, should'nt be MRRESCUE in lowercase? > - Synopsis should be "mrrescue" > - Section Desctiption: > The sentence "This manual coveres ..." is uncessary." > Maybe the text you use for d/control would be more appropiate for an > description? > - mrrescue doesn't take options, right? All fixed up. Moved to section 6. > > * d/rules: I think you don't need to rm build_dir I think I do. The build process creates a mrrescue.love file which is basically a zipped file of all the source (this is how love works). Without the rm build_dir dh_clean won't clean up properly. > * there are two pendantic lintian messages. What to do with this > strongly depends on the sponsor, however I would override it as an sign > that I've checked them (and maybe nag upstream to add an changelog and > signature to their tarballs) Override added for no upstream changelog. > So I would say the package is "almost ready"... Thanks for your > contribution :) And thanks for the review. Updated package it now uploaded to mentors. -- Steven Hamilton I don't look like two zombies -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org