Source: holotz-castle Severity: minor Tags: patch User: pkg-llvm-t...@lists.alioth.debian.org Usertags: clang-ftbfs
Hello, Using the rebuild infrastructure, your package fails to build with clang (instead of gcc). We detected this kinf of error: http://clang.debian.net/status.php?version=3.4.2&key=TAUTOLOGICAL-COMPARE Full build log is available here: http://clang.debian.net/logs/2014-06-16/holotz-castle_1.3.14-6_unstable_clang.log Thanks, Alexander -- System Information: Debian Release: jessie/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash
--- holotz-castle-1.3.14/src/HCed.cpp 2014-07-09 00:12:03.000000000 +0400 +++ holotz-castle-1.3.14-my/src/HCed.cpp 2014-07-09 00:08:22.610463365 +0400 @@ -49,7 +49,7 @@ void HCed::PrintUsage(char *program) { - fprintf(stderr, "HCed v1.3. (C) Juan Carlos Seijo Pérez - 2004.\n\n"); + fprintf(stderr, "HCed v1.3. (C) Juan Carlos Seijo Perez - 2004.\n\n"); fprintf(stderr, "Usage: %s [-t themeName] [story name] [levelToLoad]", program); fprintf(stderr, " [-h] [-r numRows] [-c numColumns]"); fprintf(stderr, " [-f]ullscreen [-w]indowed [--fps nnn] [-mWxHxBPP]\n"); --- holotz-castle-1.3.14/src/HolotzCastle.cpp 2014-07-09 00:12:03.000000000 +0400 +++ holotz-castle-1.3.14-my/src/HolotzCastle.cpp 2014-07-08 23:59:37.160061106 +0400 @@ -232,7 +232,7 @@ return false; } - if (!JApp::Init()) + if (!JApp::Init(0, 0)) { return false; } --- holotz-castle-1.3.14/JLib/JLib/Util/JApp.cpp 2009-05-02 13:17:15.000000000 +0400 +++ holotz-castle-1.3.14-my/JLib/JLib/Util/JApp.cpp 2014-07-09 00:06:38.996359392 +0400 @@ -57,7 +57,7 @@ } // Inicializa la aplicación -bool JApp::Init() +bool JApp::Init(s32 argc, char **argv) { if (-1 == SDL_Init(SDL_INIT_EVERYTHING)) { --- holotz-castle-1.3.14/JLib/JLib/Util/JApp.h 2009-05-02 13:17:15.000000000 +0400 +++ holotz-castle-1.3.14-my/JLib/JLib/Util/JApp.h 2014-07-09 00:04:41.322507594 +0400 @@ -175,7 +175,7 @@ * to do the SDL initialization stuff. * @return <b>true</b> if the creation succeded <b>false</b> if not. */ - virtual bool Init(); + virtual bool Init(s32 argc = 0, char **argv = 0); /** Updates the application objects (graphics, sounds, A.I., etc.). Must be implemented in the child class. * JApp will call this method before Draw in the child class (by means of MainLoop(). --- holotz-castle-1.3.14/src/HCPreferences.cpp 2009-05-02 13:17:15.000000000 +0400 +++ holotz-castle-1.3.14-my/src/HCPreferences.cpp 2014-07-08 23:53:41.678621912 +0400 @@ -219,7 +219,7 @@ } // Saves the preferences - if (0 > f.Printf("language=%d\nvideo=%d\nbpp=%d\nfullscreen=%d\naudio=%d\ndifficulty=%d", curLang, videoMode, bpp, fullscreen ? 1 : 0, sound ? 1 : 0, difficulty)) + if (0 == f.Printf("language=%d\nvideo=%d\nbpp=%d\nfullscreen=%d\naudio=%d\ndifficulty=%d", curLang, videoMode, bpp, fullscreen ? 1 : 0, sound ? 1 : 0, difficulty)) { // Incorrect file return 2; --- holotz-castle-1.3.14/src/HCObject.h 2009-05-02 13:17:15.000000000 +0400 +++ holotz-castle-1.3.14-my/src/HCObject.h 2014-07-08 23:51:46.376746784 +0400 @@ -118,7 +118,7 @@ /** Gets this object's position. * @return Object's position. */ - virtual const JVector & Pos() {return pos;} + virtual const JVector & Pos() const {return pos;} /** Returns the normal sprite. * @return The normal sprite. --- holotz-castle-1.3.14/JLib/JLib/Graphics/JSprite.h 2009-05-02 13:17:15.000000000 +0400 +++ holotz-castle-1.3.14-my/JLib/JLib/Graphics/JSprite.h 2014-07-08 23:49:21.619414398 +0400 @@ -143,7 +143,7 @@ */ void CurFrame(const u32 newFrame) { - if (newFrame >= 0 && newFrame < numFrames) curFrame = newFrame; + if (newFrame < numFrames) curFrame = newFrame; } /** Devuelve el frame en la posición indicada. --- holotz-castle-1.3.14/JLib/JLib/Util/JString.h 2009-05-02 13:17:15.000000000 +0400 +++ holotz-castle-1.3.14-my/JLib/JLib/Util/JString.h 2014-07-08 23:48:32.476319993 +0400 @@ -405,7 +405,7 @@ if (end == (u32)-1) end = s.Length(); - if (start >= 0 && start < s.Length() && end > start && end <= s.Length()) + if (start < s.Length() && end > start && end <= s.Length()) { length = end - start; data = new char[length + 1]; @@ -429,7 +429,7 @@ if (end == (u32)-1) end = len; - if (start >= 0 && start < len && end > start && end <= len) + if (start < len && end > start && end <= len) { length = end - start; data = new char[length + 1];