Hi, On Mon, Jul 14, 2014 at 11:43:50PM +0100, Roger Leigh wrote: > tags 718127 + patch pending > thanks > > On Sun, Jul 13, 2014 at 10:49:46PM +0100, Roger Leigh wrote: > > On Thu, Jul 10, 2014 at 10:36:28PM +0100, Roger Leigh wrote: > > > To implement this, we need session and source facets to have a > > > pointer to the parent chroot. So we query a session chroot > > > and ask if its parent was a source chroot, and also link from > > > a source chroot to plain chroot for generality and > > > completeness. Initial scoping for 1.7 (1.6 will be backported): > > > > > > - chroot to inherit enable_shared_from_this and/or switch to > > > using weak_ptr rather than bare pointers for the facet->chroot > > > back reference > > > - session and source need "shared_ptr<chroot> parent" fields > > > - session::create and source::create constructors to take a > > > "shared_ptr<chroot> parent" argument. This will be passed by > > > session_clonable::clone_session and source_clonable::clone_source, > > > respectively > > > - session can check for the presence of a source facet in its > > > parent and set SESSION_SOURCE if parent is not null and the > > > facet is present. > > > - chroot will set CHROOT_SESSION_SOURCE=true if the SESSION_SOURCE > > > flag is set, otherwise set to false. > > > > Initial implementation here: > > > > http://anonscm.debian.org/gitweb/?p=users/rleigh/schroot.git;a=shortlog;h=refs/heads/source-env > > > > (last three commits). Works as above. > > Now needs backporting to 1.6. > > Now rewritten for 1.6. I'd very much appreciate it if you could > try rebuilding 1.6.10 with these patches applied, and let me know > if it's doing what you want. Run with -v to see the value of > CHROOT_SESSION_SOURCE for source and non-source chroots. > > http://anonscm.debian.org/gitweb/?p=users/rleigh/schroot.git;a=shortlog;h=refs/heads/source-env-1.6
Thanks a lot for the quick patches. I have tried them on both 1.6.10 and 1.6.4 (with minor adjustement) as it's the version in wheezy currently used on the buildds. I have tested them with directory-, tar- and lvm-based chroots, and they behave as expected. Thanks! Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B [email protected] http://www.aurel32.net -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
