Package: terminator
Version: 0.97-3
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu utopic ubuntu-patch

Dear Maintainer,

If there are multiple terminals in a tab, the user is prompted for
confirmation. Then, the program fails to close the tab and does so silently.
Here is the bug:
https://bugs.launchpad.net/ubuntu/+source/terminator/+bug/1253995

In Ubuntu, the attached patch was applied to achieve the following:

  [ Stephen Boddy ]
  * Backport patch for tabs with multiple terminals not closing. (LP:
#1253995)

Thanks for considering the patch.

-- System Information:
Debian Release: jessie/sid
  APT prefers trusty-updates
  APT policy: (500, 'trusty-updates'), (500, 'trusty-security'), (500,
'trusty'), (100, 'trusty-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.13.0-32-generic (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

diff -Nru terminator-0.97/debian/changelog terminator-0.97/debian/changelog
diff -Nru terminator-0.97/debian/patches/fix-tab-with-multiple-terminals-not-closing.diff terminator-0.97/debian/patches/fix-tab-with-multiple-terminals-not-closing.diff
--- terminator-0.97/debian/patches/fix-tab-with-multiple-terminals-not-closing.diff	1969-12-31 18:00:00.000000000 -0600
+++ terminator-0.97/debian/patches/fix-tab-with-multiple-terminals-not-closing.diff	2014-07-28 09:27:24.000000000 -0500
@@ -0,0 +1,20 @@
+Description: Fix tab with multiple terminals not closing
+Author: Stephen Boddy <stephen.j.bo...@gmail.com>
+
+Origin: upstream, http://bazaar.launchpad.net/~gnome-terminator/terminator/trunk/revision/1490
+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1253995
+Last-Update: 2014-07-28
+
+--- terminator-0.97.orig/terminatorlib/notebook.py
++++ terminator-0.97/terminatorlib/notebook.py
+@@ -313,9 +313,7 @@ class Notebook(Container, gtk.Notebook):
+             return
+         elif maker.isinstance(child, 'Container'):
+             dbg('Notebook::closetab: child is a Container')
+-            dialog = self.construct_confirm_close(self.window, _('tab'))
+-            result = dialog.run()
+-            dialog.destroy()
++            result = self.construct_confirm_close(self.window, _('tab'))
+ 
+             if result == gtk.RESPONSE_ACCEPT:
+                 containers = None
diff -Nru terminator-0.97/debian/patches/series terminator-0.97/debian/patches/series
--- terminator-0.97/debian/patches/series	2014-07-01 11:12:40.000000000 -0500
+++ terminator-0.97/debian/patches/series	2014-07-28 09:24:52.000000000 -0500
@@ -5,3 +5,4 @@
 fix-unfocused-font-brightness.diff
 fix-maximize.diff
 fix-split-multiple-tabs.diff
+fix-tab-with-multiple-terminals-not-closing.diff

Reply via email to