Package: libembperl-perl
Version: 2.5.0-1
Severity: serious
Tags: patch

This package fails to build on current sid/amd64:

  Testing mod_perl mode...
  [...]
  #235 EmbperlObject/errdoc/epoerrdoc2.htm...ok
  #236 EmbperlObject/epobase.htm...
  Error in Line 8
  Is: ></p><
  Should: ></BODY></HTML><
  Input:      test/html/EmbperlObject/epobase.htm
  Output:     test/tmp/out.htm
  Compared to:    test/cmp/epobase.htm
  Log:        test/tmp/test.log
  Testparameter:
    errors = 1
    offline = 0
    cgi = 0
  
   ERRORS detected! NOT all tests have been passed successfully
  
  Makefile:1613: recipe for target 'test_dynamic' failed
  make[1]: *** [test_dynamic] Error 8

This diff shows the problem:

  --- test/cmp/epobase.htm    2014-07-29 14:16:55.223944564 +0300
  +++ test/tmp/out.htm    2014-07-29 14:18:46.785998659 +0300
  @@ -1,10 +1,9 @@
   <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
  -<HTML><HEAD>
  -<TITLE>403 Forbidden</TITLE>
  -</HEAD><BODY>
  -<H1>Forbidden</H1>
  -^.*?You don't have permission to access /embperl/EmbperlObject/epobase.htm
  -^on this server
  -</BODY></HTML>
  -
  -
  +<html><head>
  +<title>403 Forbidden</title>
  +</head><body>
  +<h1>Forbidden</h1>
  +<p>You don't have permission to access /embperl/EmbperlObject/epobase.htm
  +on this server.<br />
  +</p>
  +</body></html>

The apache2 error page was changed slightly by this upstream commit:

 https://github.com/apache/httpd/commit/4f8fc53c8f6df76a42ccc89275fcede766662f9e
 
https://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/modules/http/http_protocol.c?r1=1487127&r2=1610328

which was included in apache2 2.4.10, recently uploaded in sid.

Patch attached, this works for me with both 2.4.9 and 2.4.10.
-- 
Niko Tyni   nt...@debian.org
>From bcce23a15de55a39478f83a7923d8a89f681cc19 Mon Sep 17 00:00:00 2001
From: Niko Tyni <nt...@debian.org>
Date: Tue, 29 Jul 2014 14:34:35 +0300
Subject: [PATCH] Adapt to an Apache 2.4.10 error page change

The "Forbidden" error page was slightly changed by Apache commit

 https://github.com/apache/httpd/commit/4f8fc53c8f6df76a42ccc89275fcede766662f9e
 https://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/modules/http/http_protocol.c?r1=1487127&r2=1610328

breaking the EmbperlObject/epobase.htm test. The fix works
with both the old and the new page format.
---
 test/cmp/epobase.htm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/test/cmp/epobase.htm b/test/cmp/epobase.htm
index ba29386..9d0269c 100644
--- a/test/cmp/epobase.htm
+++ b/test/cmp/epobase.htm
@@ -5,6 +5,7 @@
 <H1>Forbidden</H1>
 ^.*?You don't have permission to access /embperl/EmbperlObject/epobase.htm
 ^on this server
+^-</p>
 </BODY></HTML>
 
 
-- 
2.0.1

Reply via email to