severity 745075 normal
retitle 745075 aspell: Please use autoreconf
thanks

Hi Manuel,

I'm attaching another patch (trivial) which fixes the problem,
and addresses the considerations raised.

May you please consider it for an upload?


> I could not prepare it at the moment since the patch of autotools
> seems to interfere in some way, [...]

Yes. I commented it out, since it's useless with autoreconf (it's
contents are just a 'Regeneration of autotools chain' (file header).

I didn't remove the file to keep the patch short.

> [...] and the patch proposed by the original
> submitter did not work straight away in my system (with
> pbuilder/cowbuilder).

Indeed. The problem was that patch removed autotools.mk, which is
responsible for running 'configure' [1].

This patch rather just /adds/ autoreconf.mk, resulting in autoreconf
and configure being run, correctly.

With it applied, the build finishes successfully on ppc64el, and
shared libraries are built:

# dpkg-deb -c libaspell15_0.60.7~20110707-1ppc64el1_ppc64el.deb | fgrep aspell.so -rw-r--r-- root/root 939208 2014-08-06 09:38 ./usr/lib/libaspell.so.15.2.0 lrwxrwxrwx root/root 0 2014-08-06 09:38 ./usr/lib/libaspell.so.15 -> libaspell.so.15.2.0


Thanks!

[1] http://build-common.alioth.debian.org/cdbs-doc.html#id2540579

--
Mauricio Faria de Oliveira
IBM Linux Technology Center
diff -Nru aspell-0.60.7~20110707/debian/changelog 
aspell-0.60.7~20110707/debian/changelog
--- aspell-0.60.7~20110707/debian/changelog     2011-07-29 00:27:36.000000000 
-0300
+++ aspell-0.60.7~20110707/debian/changelog     2014-08-06 09:36:17.000000000 
-0300
@@ -1,3 +1,10 @@
+aspell (0.60.7~20110707-1ppc64el1) UNRELEASED; urgency=medium
+
+  * Build with autoreconf. (Closes #745075)
+  * Disable 10_autotools.patch (thus no longer required; please remove).
+
+ -- Mauricio Faria de Oliveira <[email protected]>  Wed, 06 Aug 2014 
09:21:57 -0300
+
 aspell (0.60.7~20110707-1) unstable; urgency=low
 
   * New upstream snapshot 0.60.7-20110707
diff -Nru aspell-0.60.7~20110707/debian/control 
aspell-0.60.7~20110707/debian/control
--- aspell-0.60.7~20110707/debian/control       2011-07-29 00:27:36.000000000 
-0300
+++ aspell-0.60.7~20110707/debian/control       2014-08-06 09:36:17.000000000 
-0300
@@ -2,7 +2,7 @@
 Section: text
 Priority: optional
 Maintainer: Brian Nelson <[email protected]>
-Build-Depends: debhelper (>= 7), libncursesw5-dev | libncurses-dev, cdbs (>= 
0.4.0), texinfo
+Build-Depends: debhelper (>= 7), libncursesw5-dev | libncurses-dev, cdbs (>= 
0.4.0), texinfo, dh-autoreconf, autotools-dev
 Standards-Version: 3.9.2
 Vcs-Git: git://git.debian.org/git/collab-maint/aspell
 Vcs-Browser: http://git.debian.org/?p=collab-maint/aspell.git
diff -Nru aspell-0.60.7~20110707/debian/patches/series 
aspell-0.60.7~20110707/debian/patches/series
--- aspell-0.60.7~20110707/debian/patches/series        2011-07-29 
00:27:36.000000000 -0300
+++ aspell-0.60.7~20110707/debian/patches/series        2014-08-06 
09:36:11.000000000 -0300
@@ -4,4 +4,4 @@
 04_gcc43_build_fix.diff
 05_doc_fix.diff
 07_filter.diff
-10_autotools.diff
+#10_autotools.diff
diff -Nru aspell-0.60.7~20110707/debian/rules 
aspell-0.60.7~20110707/debian/rules
--- aspell-0.60.7~20110707/debian/rules 2011-07-29 00:27:36.000000000 -0300
+++ aspell-0.60.7~20110707/debian/rules 2014-08-06 09:36:45.000000000 -0300
@@ -2,6 +2,7 @@
 
 include /usr/share/cdbs/1/rules/debhelper.mk
 include /usr/share/cdbs/1/class/autotools.mk
+include /usr/share/cdbs/1/rules/autoreconf.mk
 
 DEB_DH_MAKESHLIBS_ARGS_ALL := -V'libaspell15 (>= 0.60.7~20110707)' 
-Xusr/lib/aspell
 

Reply via email to