Od: Tobias Frost <t...@debian.org>
Hello Tobias, "- d/copyright is incomplete, there are at least 2 files not documented for the 3rdParty folder. (CGetOpt.cpp and main.cpp) (The html file in this dir is obviously generated by doxygen), the examples gpx are also not in the copyright file. There are two animated gifs in src/animated, which are Loading "indicators are from: http://ajaxload.info/"; (README in the file) The site says "The gifs are totally free to use" .. This unfortunatly does satisfy the DFSG rules, as for example the permissions for modifying, distribution are not included. (So maybe contact the ownder of ajaxload.info, because I assume that they are just not aware of the fine details of copyright law) Also there are three png without source in cursors .. one of the files refer to a "Eric" (string in file), so also here upstream needs to clearify copyright situation. (A image search on the net indicates that this cursors are public domain.. http://www.rw-designer.com/cursor-set/ proton) in src/icons/cache/COPYRIGHT I read "All icons in this directory are from the Open Cache Manager project http://opencachemanage.sourceforge.net/"; Checking that site tells me that that project has released files under Apache 2.0.... Stopping here on checking copyright; you need to work through it again and probably also ask upstream to take a little bit more care to more carefully document licenses... The manpage is basically empty. Please extent it (and submit it upstream.) Nitpicks: As you are already repacking, - you could also remove all the pre-generated icons (as you should regenerate them at build-time from the svgs :)) - you could e.g xz as compression method, instead of gz. The other files in debian/ just need a wrap-and-sort run over it :) Can you check if the override of the autoinstall target could be done with an d/install file?" I already managed to fix few issues in packaging repo: http://anonscm.debian.org/cgit/pkg-grass/qmapshack.git I also contacted upstream and informed about licensing problems. Things will be hopefully fixed with next upstream release. Biggest problem seems to be files src/animated, which are loading indicators from: http://ajaxload.info/"; I can't find any contact on Yannick Croissant ( creator of pages) anywhere : ( He is quite active in many projects, but nowhere is possible get email. Any advice on this? Thank you for reviewing. best regards Jaromir Mikes
