Control: severity -1 important On Mon, 07 Jul 2014 12:08:37 +0930, Ron wrote:
> While working on improving cowpoke, I noticed that cowbuilder was
> passing the --debbuildopts option to pbuilder twice, something like
> this:
>
> forking: pbuilder build --aptcache ... --debbuildopts -uc -us -j6
> --buildplace ... --buildresult ... --debbuildopts -uc -us -j6 --no-targz ...
>
> (I trimmed out the junk, but the order of options there is intact).
Right, and that becomes problematic if you try to pass
--debbuildopts --changes-option=-g
because dpkg-genchanges chokes on the duplicated -g.
Raising the severity accordingly.
> This would appear to be because in parameter.c we have:
>
> else if (!strcmp(long_options[index_point].name,"debbuildopts"))
> {
> /* this is for qemubuilder */
> pc.debbuildopts=strdup(optarg);
>
> /* pass it for cowbuilder */
> PASS_TO_PBUILDER_WITH_PARAM
> }
>
>
> While in cowbuilder.c we also have:
>
> if (pc->debbuildopts)
> {
> PBUILDER_ADD_PARAM("--debbuildopts");
> PBUILDER_ADD_PARAM(pc->debbuildopts);
> }
>
>
> Which adds it to the pbuildercommandline[] a second time, right
> after --buildresult.
>
> One of those can probably go away :)
I quickly commented out the lines in cowbuilder.c, and indeed got
only one --debbuildopts.
Cheers,
gregor
--
.''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
: :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/
`. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
`- NP: Bob Dylan: Not Dark Yet
signature.asc
Description: Digital Signature
