Hi Andrey, thanks for the nice review!
> Il Domenica 24 Agosto 2014 20:11, Andrey Rahmatullin <w...@debian.org> ha > scritto: > > Can you please not use abbreviations such as "d/c" and > "std-version" in > > d/c? corrected > > Don't use ${python:Provides}. > removed. > At least some of the d can be made r, such as mtd-utils. I don't fully agree (I don't honestly know the tradeoff between a bad user experience and the amount of the packages that one might be forced to install), but fine, I changed that > > Why Priority: extra? > Changed to optional, it was a leftover from the previous upload, I didn't change that > There are several issues with the manpage, 3 of them are reported by > lintian and fourth one is the "SEE ALSO" section which is not true. > they are created with help2man binwalk --version-string=v2.0.1 > binwalk.1 should I file a bug there? Sorry but I don't feel good in fixing automatically created files... do you have any advice for this? Still many thanks for the review, I'm attaching the patch I just added on mentors for your convenience From 11ae61f20272b2dd27d4fcf2b04a047243a851a9 Mon Sep 17 00:00:00 2001 From: Gianfranco Costamagna <costamagnagianfra...@yahoo.it> Date: Mon, 25 Aug 2014 01:21:39 +0200 Subject: [PATCH] Update, per wRAR feedback --- debian/changelog | 18 +++++++++++------- debian/control | 5 ++--- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/debian/changelog b/debian/changelog index b1ec7b2..9a2ab0a 100644 --- a/debian/changelog +++ b/debian/changelog @@ -2,14 +2,18 @@ binwalk (2.0.1-1) unstable; urgency=medium * Imported Upstream version 2.0.1 (Closes: #727553, Closes: #754317) - Updated docs location - * d/r: Removing binary files when cleaning - * d/c: X-Python-Version: >= 2.7 - * d/p/destdir.patch: Override install path - * Add some b-d and d - * Bump std-version to 3.9.5, no changes required + * Tweak rules file to remove binary files when cleaning. + * debian/control: add X-Python-Version: >= 2.7 and + some new dependencies such as python-pyqtgraph. + * debian/control: add python-opengl python-qt4 and python-qt4-gl + as depdencies, to force the right pyqtgraph render engine. + * patch destdir.patch, add DESTDIR to install path. + * Add dh-autoreconf as build-dependency, and some missing runtime dependencies, + needed to correctly extract the various kind of supported files. + * Bump standard version to 3.9.5, no changes required. * Add myself to uploaders. - * d/{control,watch,copyright} New website (Closes: #734708) - * Canonical VCS urls. + * debian/{control,watch,copyright} New website (Closes: #734708) + * Update VCS fields to canonical. * Update man page. * Update copyright file. diff --git a/debian/control b/debian/control index 49d3753..9e17cc9 100644 --- a/debian/control +++ b/debian/control @@ -1,6 +1,6 @@ Source: binwalk Section: devel -Priority: extra +Priority: optional Maintainer: Leo Costela <cost...@debian.org> Uploaders: Gianfranco Costamagna <costamagnagianfra...@yahoo.it> Build-Depends: debhelper (>= 9), @@ -17,7 +17,6 @@ Architecture: any Depends: ${python:Depends}, ${shlibs:Depends}, ${misc:Depends}, python-matplotlib, python-pyqtgraph, - mtd-utils, ncompress, bzip2, arj, @@ -29,7 +28,7 @@ Depends: ${python:Depends}, ${shlibs:Depends}, ${misc:Depends}, python-opengl, python-qt4, python-qt4-gl -Provides: ${python:Provides} +Recommends: mtd-utils Description: tool for searching binary images for embedded files and executable code Binwalk is a tool for searching a given binary image for embedded files and executable code. Specifically, it is designed for identifying files -- 1.9.1 Have many thanks, Gianfranco > -- > WBR, wRAR > -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org