Control: tag -1 - patch

Hi Gianfranco,

On Wed, Aug 20, 2014 at 1:21 AM, Gianfranco Costamagna
<costamagnagianfra...@yahoo.it> wrote:

> the problem should be if I understand correctly the code, when "$instdir" 
> contains some special chars such as "-", in that case the build fails.

Ah, you're right, the script doesn't handle that very nicely:

$ pwd
/tmp/b po*'&\h
$ make-googleearth-package
Google Earth for GNU/Linux 6.0.3.2197
Supported Google Earth version: 6.0.3.2197
tar: Pattern matching characters used in file names
tar: Use --wildcards to enable pattern matching, or --no-wildcards to
suppress this warning
tar: po*'&\\h/googleearth-tmp: Not found in archive
tar: Exiting with failure status due to previous errors
tar: /tmp/b po*'&\\h/googleearth-tmp/googleearth-linux-x86.tar: Cannot
open: No such file or directory
tar: Error is not recoverable: exiting now
tar: /tmp/b po*'&\\h/googleearth-tmp/googleearth-data.tar: Cannot
open: No such file or directory
tar: Error is not recoverable: exiting now
cp: cannot stat ‘/tmp/b po*'&\\h/googleearth-tmp/googleearth.xpm’: No
such file or directory
cp: cannot stat ‘/tmp/b po*'&\\h/googleearth-tmp/README*’: No such
file or directory
[...]

(the resulting .deb package is broken)

Your/Ubuntu's proposed patch doesn't fix this, however, so untagging
patch from the bug report.

> looking at the code instdir starts from the current directory, so maybe it 
> really depend from where are you calling the make command...
>   local instdir="`pwd`/googleearth-deb"
>   local tmpdir="`pwd`/googleearth-tmp"

Urgh, that really should be using "mktemp -d" instead of predictable
directory names.

Regards,
Vincent


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to