Following.

I've rechecked 0.2.14-3 and PageUp/PageDown for page turning aren't yet working on my Laptop, is that reproducible?

Greetings,
Daniel

On 04.09.2014 03:46, Olly Betts wrote:
On Wed, Sep 03, 2014 at 01:43:39PM +0200, Jakub Wilk wrote:
* Olly Betts <o...@survex.com>, 2014-08-24, 03:53:
I'm not sure why it doesn't just work (as
wxPython/demo/TreeCtrl.py from the wxPython 3.0 sources does and
the code is very similar) but adding a handler for EVT_RIGHT_CLICK
which calls EditLabel() makes it work as before.

Wait, _right_ click? With wxPython 2.8, if you had wx.TR_EDIT_LABELS
in the style, you could edit stuff with _left_ click.

There's something odd here, which I can't entirely explain.

These editable labels aren't a feature I've used before, and the wx docs
seem silent on how you are meant to actually trigger an edit.  So I
experimented using demo/TreeCtrl.py in the wxPython sources.

With that, you have to *right* click on an item to edit its label, so
that's the behaviour I reproduced in my patch.

But looking more closely at the code of that demo, the rather odd thing
is that it doesn't actually enabled wx.TR_EDIT_LABELS - there's a line
for it, but it is commented out.  If you turn it on, then left click
also edits (as you say).

You might need to similarly fix the other wx.TreeCtrl - the djvu
file I had to hand for testing had no text so I couldn't check
that.

I use /usr/share/doc/libdjvulibre-dev/djvulibre-book-ru.djvu for
testing.

Thanks, that's a much more useful file for testing.

The attached patch fixes edits to work in both the controls on left
click (which is the "ACTIVATED" event).

Cheers,
     Olly

--
https://qa.debian.org/developer.php?login=debian%40danielstender.com
PGP key: 2048R/E41BD2D0
C879 5E41 1ED7 EE80 0F2E 7D0C DBDD 4D96 E41B D2D0


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to