Rodolfo García Peñas (kix) wrote, On 2014-08-11 13:02: > Pedro sent some patches to Debian BTS (see [1]). Patches are nice, but > they have some things that I am not sure if they are ok for us. My > comment is about the change from CC to GCC compiler and use gcc specific > definitions: > > 1. Change the CC compiler to gcc (wmmon-1.1%2B20120402.patch [2]) > 2. Usage the llong, perhaps gcc specific [2] > 3. Include a new file in the library wmgeneral. I think wmgeneral is a > common library. Perhaps we should create a new library libwmgeneral in > the dockapps repo and link/include the dockapps to them (see wmSMPmon, > wmbiff, wmckgmail,wmitime, wmmon,...). > > kix > > > [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=670151 > [2] > https://bugs.debian.org/cgi-bin/bugreport.cgi?msg=20;filename=wmmon-1.1%2B20120402.patch;att=1;bug=670151
Let me clarify some misunderstandings. Point 1 is not necessary with the latest patch. There are two patches that do things differently. The first one used 'long long' and needed a change of compiler; I wrote the second one to remove that problem. About point 2, 'llong' is a user-defined type, not in any way gcc-specific. It should work with any compiler. My code additions should work with ANSI C89. The type that is C99-specific (not exactly gcc-specific, but gcc added it as an extension even in C89 mode) is 'long long' and is not used by default, because HAVE_LONG_LONG is not defined by anything. The HAVE_LONG_LONG macro can be tested in configure. Actually the patch should probably be rewritten once more so that the macro is called HAVE_LONG_LONG_INT instead, see https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Particular-Types.html , in particular AC_TYPE_LONG_LONG_INT. I can't handle autoconf so I didn't make any changes to configure to test for it. Someone who knows what they're doing can implement it. Point 3 is correct. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
