tags 341160 + confirmed
thanks

I made a new package of tecnoballz and uploaded it to dak.ganneff.de,
it's waiting for approval in the NEW queue.

Le lundi 28 novembre 2005 à 21:09 +0100, [EMAIL PROTECTED] a écrit :

>  * Does tecnoballz not compile with g++ < 4? If it does, please remove
>    the build-dependency. Sources changed to compile with g++ 4.0 should
>    also work with earlier versions. You should only target sid which has
>    g++ 4.0 on all architectures now, an explicit dependency is not
>    required.
Indeed, tecnoballz compiles nicely with older g++ versions. I changed
the dependency to "g++".

>  * You should include the copyright notice taken verbatim from the
>    source code.

It's already included, verbatim from upstream in debian/copyright.

>  * There is `technoballz.substvars' in the diff, because the package name
>    was once spelled wrong. Please remove it.

Removed.

>  * Shouldn't you ensure permissions with statoverride as specified above
>    instead of overwriting them in any case in `postinst'?

Done, I changed tecnoballz.postinst in order to use dpkg-stateoverride
for chmoding the score file.

>  * The following part is wrong [cf. Policy 10.1]:
>    | ifneq (,$(findstring nostrip,$(DEB_BUILD_OPTIONS)))
>    |        CXXFLAGS += -g
>    | else
>    |        CXXFLAGS += -s
>    | endif

Ah, I forgot this one, will do a new upload soon.

Regards.

-- 
Alexis Sukrieh <[EMAIL PROTECTED]>

Reply via email to