David, Thank you for your report and your interest in Debian.
It seems the code in buildbot/scripts/upgrade_master.py really exits upgrade process if there's a problem with buildbot.tac file. This means the message should be an ERROR and the text should be more descriptive telling you what to change and retry upgrade. As it is noted in upstream bug #2588 you mentioned [1], there's no simple way to automatically fix buildbot.tac file during upgrade. So this task will be left on the user to be handled manually. I'll add more information in /usr/share/doc/buildbot/NEWS.Debian As for other files you mentioned (public_html/*.new), these are created every time you run upgrade-master command. You may remove *.new suffix to apply them to your setup of remove these files at all. Upgrade process when files are overwritten if they weren't changed by user is currently not implemented. Please contact upstream developers to fix this. New master.cfg.sample config file is also an example of configuration file created after every upgrade-master command. Buildbot upstream has a great deal of supporting old configuration values for some time before deprecating. Release notes for 0.8.9 show this [2]: * slavePortnum option deprecated, please use c['protocols']['pb']['port'] to set up PB port This option is deprecated but not removed so you still can use it in this release (but keep in mind to fix it for later upgrades). So that was not exact issue you spotted when master didn't start. Moreover, I have multiple buildbot masters running at hand that have slavePortnum option. I wonder what your problem really was. At last, permission and owner checks before running upgrade would be good but seems to me not mandatory. You could run upgrade-master command from another user just using su or sudo. This is generally a good assumption that administrator checks permissions beforehand. Thank you again. [1]: http://trac.buildbot.net/ticket/2588 [2]: http://docs.buildbot.net/0.8.9/relnotes/index.html#deprecations-removals-and-non-compatible-changes -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
