I went through all suggestions. Since I made some changes to the upstream code, as suggested, I released a new version of the source tarball (1.2.3). The extension of the tarball is now tar.xz, for higher compression. I also uploaded a new package to Mentors with all the changes. Since the version was changed, the new path to the dsc is: http://mentors.debian.net/debian/pool/main/d/drmips/drmips_1.2.3-1.dsc
I think I fixed all issues/suggestions. Some important remarks follows. > 1. Change the DH level from 8 to 9. I changed debian/compat to 9. I also updated the debhelper build-dependency on debian/control to (>= 9.0.0). Is that correct? > 2. d/control: (...) I changed the section to 'java'. > 3. d/copyright: (...) I think I'm listing all copyrights now, and I'm using the license texts in /usr/share/debhelper/dh_make/licenses/. But it needs to be checked. The BSD-3-Clause that I used needs to be checked (more specifically, the "copyright holder" in the 3rd clause). Also, in src/pc/DrMIPS/src/com/jtattoo/plaf, there are three files (BaseTabbedPaneUI.java, BaseTitlePane.java and BaseInternalFrameTitlePane.java) that have this comment above the JTattoo license (by MH Software-Entwicklung): /* * Copyright 2003 Sun Microsystems, Inc. All rights reserved. * SUN PROPRIETARY/CONFIDENTIAL. Use is subject to license terms. */ This looks strange. Is this a problem? What should I do about this? Note: these files are new. They were added to "fix" issue/suggestion 7 (explained below). > 5.d/links: I didn't understand your intend with this file. I added a patch to the package to install the PDF manuals to /usr/share/doc/drmips/manuals, and used the debian/links file to create a link from /usr/share/drmips/doc to /usr/share/doc/drmips/manuals (this is acceptable, right?). I also added two doc-base control files, as suggested by lintian. > 7. After build we have some Lintian messages that you can solve (as > packager and as upstream): > > a. Maybe you can solve: > > P: drmips source: source-contains-prebuilt-java- > object > src/android/DrMIPS/libs/android-support-v4.jar > P: drmips source: source-contains-prebuilt-java-object > src/pc/DrMIPS/lib/JTattoo.jar > P: drmips source: source-contains-prebuilt-java-object > src/pc/DrMIPS/lib/autocomplete.jar > P: drmips source: source-contains-prebuilt-java-object > src/pc/DrMIPS/lib/rsyntaxtextarea.jar The first library was not really being used, so it was removed. (Even if it had not been removed, it was not being used by this package). The others were replaced by their source code. -- Bruno Nova
