On 01.12.05 13:46:21, Bart Samwel wrote: > Andreas Pakulat wrote: > >On 30.11.05 13:18:04, Bart Samwel wrote: > >>You added the option but probably didn't recreate the journal file itself. > >>Try "tune2fs -J /dev/hda2". > >It's a small "j", but anyway it's ok now. But this leads to the > >following: Why did laptop-mode-tools try to remount my / with commit? > >Does it rely on /etc/fstab for the FS type? If this is the case, could > >it be improved to use /proc/mounts instead, so that it checks the "real" > >FS type and not the "declared" one? > > Hmmm, when I developed this /proc/mounts didn't show the "real" type. Of the > lines in your /proc/mounts: > > rootfs / rootfs rw 0 0 > /dev/root / ext2 rw,nogrpid 0 0 > > I got only the first one at the time. Perhaps it's time to fix that now. > However, usually a mismatch between /etc/fstab (or /etc/mtab) and > /proc/mounts > is something that people would actually want to *fix*. You were unknowingly > running your root fs without journalling, and this seems to be the general > case: I've only really heard about the BIG FAT WARNING from people who were > *really surprised* that their root fs was mounted as ext2 instead of ext3. > For > that reason I'm not really in a hurry to remove the warning. :)
Hmm,in that case leaving the Warning is probably best, but you could remove the mount -o remount,commit in the case where an ext3 is mounted as ext2. Also I think the warning could mention something like "only /proc/mounts shows the real fstype, mount and /etc/mtab lie in the case of "/"" Andreas -- It's lucky you're going so slowly, because you're going in the wrong direction.
pgpPebouyXN1X.pgp
Description: PGP signature
