On 2014-09-29 23:19:51, Svante Signell wrote: > Source: handbrake > Version: 0.9.9+svn6422+dfsg1-1 > Severity: important > Tags: patch > User: [email protected] > Usertags: hurd > > Hi, > > Currently handbrake fails to build from source due to usage of > PATH_MAX, which is not defined on GNU/Hurd. Another issue is missing > linkage with libpthread, the same as for kFreeBSD, see #730976 > > For the PATH_MAX issues strcmp and strlen are used instead of strncmp > and strnlen, respectively. According to the submitters knowledge there > is no big difference between these functions, and the chosen functions > avoid the on some systems undefined constant PATH_MAX. If there is a > wish to keep the old code a conditional test can easily be made, please > let me know, and I'll create a patch depending on if PATH_MAX is > defined or not.
Since I cannot test the patch, could you please forward it upstream? See the "Submitting a patch" section at https://handbrake.fr/contribute.php. Cheers -- Sebastian Ramacher
signature.asc
Description: Digital signature
