Thank you for the code review. :) [Ben Hutchings] > The firmware agent is never coming back, so please do remove the related > code.
I know and agree, but <URL: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=725714#163 > asked for the non-working code to be kept to work with older kernels. I do not have any strong feelings, so I left it as it was. > This belongs in the changelog not the code. Actually, as long as there are several blocks doing similar things, I believe an explanation should be close to the code to explain why. I will wonder when I return in a few years time. :) > The driver name should appear at the start of the log line (after > the timestamp). Use that instead of 'kernel'. Yeah, but did not find a simple way to do it, and it is not affecting the functionallity, only the user messages. Should probably be fixed in the final version. > Redundant use of grep; sed can do that (sed -n 's/.../.../p'). Yeah. > Indentation of the above is inconsistent with the surrounding code > (4 spaces vs hard tab). It will happen before any commit is done. -- Happy hacking Petter Reinholdtsen -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
