Hi Julien,
On 10/15/2014 05:45 AM, Julien Cristau wrote:
The 'add ppc64el support' patch seems to make the other one unnecessary,
since -mminimal-toc is only added for ppc64architecture, which wouldn't
apply to ppc64el? Am I missing something?
It happens the patch doesn't disable the ppc64architecture, it just adds
the ppc64el architecture - so if you're in powerpc64 and little endian,
both are defined (see there's no #else in this piece):
+ # ifdef __powerpc64__
++# ifdef __LITTLE_ENDIAN__
++# ifndef Ppc64elArchitecture
++# define Ppc64elArchitecture
++# endif
++# endif
+ # ifndef Ppc64Architecture
+ # define Ppc64Architecture
+ # endif
I haven't discussed the patch with its author. Do you believe this point
should be handled differently? (i.e., use an #else)
One thing I had in mind when writing the other patch was trying not to
modify existing stuff, so not to break what used it before, so maybe
that fits here too - ppc64el is also some sort of ppc64, except for
the endianness-dependent pieces.
Also, have any of these patches been sent upstream?
I don't think so. I'd be happy to submit them (w/ the other author's
acknowledgement) if you/other maintainers are OK w/ them (as you're
more experienced - I only looked at a small piece for fixing it).
Thanks!
--
Mauricio Faria de Oliveira
IBM Linux Technology Center
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
