On 05/11/14 14:40, Holger Levsen wrote: > Hi, > > On Dienstag, 4. November 2014, Ximin Luo wrote: >> OK, I've uploaded a release candidate to mentors, same address as above. > > I took a look, and there are two or three problems, though the fix itself is > mostly fine I think :-) > > 1. bumping the standards version now is often perceived as unwanted noise by > those reviewing the changes to decide whether to let it enter jessie. leave > it > now, but next time please only include non-cosmetic changes _if_ you add non > ron-RC fixes at all. >
OK. > 2. your fix for #765156 looks good to me, I just wonder whether in the > following it really should only be 20 and not 40 or 100... are you sure that > safe enough now and in 5 years? > > ++ for i in xrange(0, 20): > > (I think so, as hw gets faster but... maybe 40 is still better as there > could > be even slower hw??) > The previous sleep time was 0.1s, and now it will sleep for a maximum of 1s (10 times the previous), so I think this should be OK. > 3. there are lot of changes in debian/rules between 1.7-1 and 1.7-2 and > there's no mentioning of those in debian/changelog at all. Is there a bug# > for > the problem they are fixing? > I just noticed that I wasn't running some of the tests, that's all it is (and some variable renames for consistency). So I figured this is too trivial to put in debian/changelog, and there is no effect on the binary packages. X -- GPG: 4096R/1318EFAC5FBBDBCE git://github.com/infinity0/pubkeys.git
signature.asc
Description: OpenPGP digital signature
