Package: release.debian.org Severity: normal User: release.debian....@packages.debian.org Usertags: unblock
Please unblock package signing-party Hi there, I would like to upload the attached changes: a regression bug has been introduced in signing-party 1.1.10-1, making caff violate RFC 2822 when sending messages with a non-English locale. This fixes bug RC #767371. (A previous unblock request has been filled — #768503, but the version to unblock, namely 1.1.10-2, was not fixing RC #767371 bug. My bad, sorry for that.) unblock signing-party/1.1.10-3 -- System Information: Debian Release: jessie/sid APT prefers unstable APT policy: (990, 'unstable'), (800, 'testing'), (700, 'stable'), (1, 'experimental') Architecture: i386 (i686) Kernel: Linux 3.16-3-686-pae (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Thanks! Cheers, -- Guilhem.
diff -Nru signing-party-1.1.10/debian/changelog
signing-party-1.1.10/debian/changelog
--- signing-party-1.1.10/debian/changelog 2014-10-11 23:09:24.000000000
+0200
+++ signing-party-1.1.10/debian/changelog 2014-11-08 02:02:16.000000000
+0100
@@ -1,3 +1,13 @@
+signing-party (1.1.10-3) unstable; urgency=medium
+
+ [ Guilhem Moulin ]
+ * caff:
+ + Fix RCF 2822 violation: Never localize the "Date" header, regarless of
+ the LC_ALL, LC_TIME and LANG in use. Regression introduced in r698.
+ (Closes: #767371)
+
+ -- Guilhem Moulin <guil...@guilhem.org> Fri, 07 Nov 2014 21:35:13 +0100
+
signing-party (1.1.10-1) unstable; urgency=low
* debian.compat:
diff -Nru signing-party-1.1.10/debian/patches/bug767371.diff
signing-party-1.1.10/debian/patches/bug767371.diff
--- signing-party-1.1.10/debian/patches/bug767371.diff 1970-01-01
01:00:00.000000000 +0100
+++ signing-party-1.1.10/debian/patches/bug767371.diff 2014-11-08
02:02:16.000000000 +0100
@@ -0,0 +1,47 @@
+From: Guilhem Moulin <guil...@guilhem.org>
+Subject: [PATCH] Cherry-pick r721 to fix RC bug #767371.
+Date: Thu Oct 30 16:54:16 2014 +0000
+
+Fix RCF 2822 violation: Never localize the "Date" header.
+
+diff --git a/caff/caff b/caff/caff
+index 696c0c1..ae4bffd 100755
+--- a/caff/caff
++++ b/caff/caff
+@@ -383,7 +383,7 @@ use Fcntl;
+ use IO::Select;
+ use Getopt::Long;
+ use GnuPG::Interface;
+-use POSIX qw{strftime};
++use POSIX qw{strftime setlocale};
+
+ my %CONFIG;
+ my $REVISION = '$Rev: 710 $';
+@@ -908,7 +908,7 @@ sub create_mail($$$@) {
+ };
+
+ $message_entity->head->add("From", Encode::encode('MIME-Q',
$CONFIG{'owner'}).' <'.$CONFIG{'email'}.'>');
+- $message_entity->head->add("Date", strftime("%a, %e %b %Y %H:%M:%S %z",
localtime));
++ $message_entity->head->add("Date", strfCtime("%a, %e %b %Y %H:%M:%S
%z", localtime));
+ $message_entity->head->add("Subject", "Your signed PGP key 0x$key_id");
+ $message_entity->head->add("To", email_to_ascii($address));
+ $message_entity->head->add("Sender", Encode::encode('MIME-Q',
$CONFIG{'owner'}).' <'.$CONFIG{'email'}.'>');
+@@ -1175,6 +1175,18 @@ sub import_keys_to_sign() {
+ return 0;
+ }
+
++##
++# A non-localized version of POSIX::strftime.
++#
++sub strfCtime($@) {
++ my $lc_time = setlocale(POSIX::LC_TIME);
++ setlocale(POSIX::LC_TIME, 'C');
++ my $str = strftime(@_);
++ setlocale(POSIX::LC_TIME, $lc_time);
++ return $str;
++}
++
++
+ ###################
+ # argument handling
+ ###################
diff -Nru signing-party-1.1.10/debian/patches/series
signing-party-1.1.10/debian/patches/series
--- signing-party-1.1.10/debian/patches/series 2014-10-11 23:09:24.000000000
+0200
+++ signing-party-1.1.10/debian/patches/series 2014-11-08 02:02:16.000000000
+0100
@@ -1 +1,2 @@
gpgwrap_makefile.diff
+bug767371.diff
signature.asc
Description: Digital signature
