Package: litl
Severity: grave
Version: 0.1.1+dfsg-3
Tags: patch

litl uses -march=armv7-a whenever it detects an arm system. This is pointless on debian armhf (the compiler already has it as a built-in default) and wrong on debian armel and raspbian where it will render the package unusable on the minimum hardware supported by those ports. This needs to be fixed.

Apologies for not pushing this back to Debian earlier I noticed and patched it in raspbian a while back but either I didn't realise that the block of code in question also applied to armel or I didn't get arround to filing a bug.

Debdiff attatched, no intent to nmu.

diff -Nru litl-0.1.5+dfsg/debian/changelog litl-0.1.5+dfsg/debian/changelog
--- litl-0.1.5+dfsg/debian/changelog    2014-06-10 12:00:14.000000000 +0000
+++ litl-0.1.5+dfsg/debian/changelog    2014-11-23 23:42:15.000000000 +0000
@@ -1,3 +1,11 @@
+litl (0.1.5+dfsg-1.1) UNRELEASED; urgency=medium
+
+  * Patch proposed to bug report, no intent to NMU.
+  * Don't use -march=armv7-a, it's pointless on Debian armhf and wrong on
+    Debian armel and Raspbian.
+
+ -- Peter Michael Green <plugw...@debian.org>  Sun, 23 Nov 2014 23:41:25 +0000
+
 litl (0.1.5+dfsg-1) unstable; urgency=medium
 
   * New upstream release.
diff -Nru litl-0.1.5+dfsg/debian/patches/dont-use-march-on-arm 
litl-0.1.5+dfsg/debian/patches/dont-use-march-on-arm
--- litl-0.1.5+dfsg/debian/patches/dont-use-march-on-arm        1970-01-01 
00:00:00.000000000 +0000
+++ litl-0.1.5+dfsg/debian/patches/dont-use-march-on-arm        2014-11-23 
23:30:54.000000000 +0000
@@ -0,0 +1,16 @@
+Description: Don't use -march=armv7-a on arm
+ -march=armv7-a is pointless on debian armhf (the compiler already has it as 
+ a built-in default) and wrong on debian armel and raspbian where it will 
+ render the package unusable on the minimum hardware supported by those ports. 
+
+--- litl-0.1.5+dfsg.orig/configure.ac
++++ litl-0.1.5+dfsg/configure.ac
+@@ -66,7 +66,7 @@ case "$host" in
+         arm*-*)
+         AC_MSG_WARN([ARCH: ARM])
+                 arch_str="ARM"
+-        CFLAGS="$CFLAGS -marm -march=armv7-a"
++        CFLAGS="$CFLAGS -marm"
+                 ;;
+         *)
+                 AC_MSG_WARN([unknown architecture: falling back to x86_64])
diff -Nru litl-0.1.5+dfsg/debian/patches/series 
litl-0.1.5+dfsg/debian/patches/series
--- litl-0.1.5+dfsg/debian/patches/series       2014-06-10 11:57:14.000000000 
+0000
+++ litl-0.1.5+dfsg/debian/patches/series       2014-11-23 23:29:10.000000000 
+0000
@@ -1 +1,2 @@
 nested_function
+dont-use-march-on-arm

Reply via email to