On dom, nov 30, 2014 at 03:06:55 +0100, Tobias Frost wrote: > Am Sonntag, den 30.11.2014, 00:21 -0800 schrieb Tom Lee: > > Alrighty, talking this over with Alessandro he made the case that we > > should keep tests that don't rely on external network connections. See > > e.g. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=753944 which > > makes the case for a loopback interface in pbuilder. > > > > > Tobi, to that effect I modified your patch to keep the tests that work > > fine with localhost & thus pass in pbuilder. > > I'm ok with everything that fixes this bug :) > > Note that the above pbuilder bug is not closed yet;
pbuilder does create a loopback interface with USENETWORK=no, but, according to that bug report, it still has problems... which makes me wonder, what if this FTBFS is actually caused by a bug in pbuilder? > also buildds using AFAIK a sbuilder setup. > https://wiki.debian.org/buildd explicitly says not to expect *any* > network interface to be available. The part about missing a loopback was actually removed from that page years ago [0]. Not to mention that disabling valuable and working (at least on the Debian buildds) tests over a matter of "policy" (and a confusing one at that) seems silly to me. All buildds provide at least a loopback interface or hiredis (and many other packages) would have never been able to build in the past. And pbuilder somehow screws this up. > A test-upload to expermental maybe could give some hint if your patch is > enough? I don't see how an upload would be useful in this case. hiredis is not failing to build on the buildds, and a new upload (even without patch) would only confirm that. > > Also, I feel like the "serious" severity is overstating the issue > > given that 0.11.0-4 builds fine in buildd/sbuild. Alessandro pointed > > out the periodic rebuilds would have revealed this issue otherwise. > > > > > If there are no objections I'd like to propose we adjust the severity > > of this bug to "normal" & leave the fix for this particular bug until > > after the Jessie freeze. > > Here I can reprodcue the FTBFS locally with pbuilder 0.215+nmu3, so > I disagree. It maybe has not been detected *yet*? What does this "yet" even mean? Except inside pbuilder, hiredis builds fine [1]. The fact that it fails *only* inside pbuilder (and the fact that hiredis is not the only package in this situation) suggests that this is indeed a pbuilder bug. I really don't see how this is release critical in any way on the part of the hiredis package. Cheers [0] https://wiki.debian.org/buildd?action=diff&rev1=11&rev2=12 [1] https://buildd.debian.org/status/package.php?p=hiredis&suite=unstable
signature.asc
Description: Digital signature
