Bug#772764: breaks API

[Джонатан Вашингтон]

This patch also appears to break the API.

The following lines

        if ( preg_match( &#039;/\<\s*cross-domain-policy\s*\>/i&#039;,
$json ) ) {
            $json = preg_replace(
                &#039;/\<(\s*cross-domain-policy\s*)\>/i&#039;,
&#039;\\u003C$1\\u003E&#039;, $json
            );
        }

should be

        if ( preg_match( '/\<\s*cross-domain-policy\s*\>/i', $json ) ) {
            $json = preg_replace(
                '/\<(\s*cross-domain-policy\s*)\>/i', '\\u003C$1\\u003E', $json
            );
        }

Otherwise the API returns 500 errors and the following appears in the error log:
[error] PHP Fatal error: Call-time pass-by-reference has been removed
in /usr/share/mediawiki/includes/api/ApiFormatJson.php on line 77

Fix was identified by the friendly folks in freenode#mediawiki :)

-- 
Jonathan


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org