Package: uci2wb
Version: 2.0-1
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu vivid ubuntu-patch

Dear Maintainer,

In Ubuntu, we use ld --as-needed by default in the toolchain, and you package 
fails to build from source with that option enabled because of the way 
libraries are linked.

Even though Debian doesn't use ld --as-needed by default, it is a good idea to 
make this change so that (1) we don't have to maintain a delta and (2) you 
don't need to change anything in case Debian makes this default in the future.

You can read more about this option here: 
https://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries

In Ubuntu, the attached patch was applied to achieve the following:

  * debian/patches/as-needed.patch: Put libraries after objects to fix FTBFS
    with ld --as-needed.

Thanks for considering the patch.

Logan Rosen

-- System Information:
Debian Release: jessie/sid
  APT prefers vivid-updates
  APT policy: (500, 'vivid-updates'), (500, 'vivid-security'), (500, 'vivid'), 
(100, 'vivid-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-25-generic (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru uci2wb-2.0/debian/patches/as-needed.patch uci2wb-2.0/debian/patches/as-needed.patch
--- uci2wb-2.0/debian/patches/as-needed.patch	1969-12-31 19:00:00.000000000 -0500
+++ uci2wb-2.0/debian/patches/as-needed.patch	2014-12-16 03:01:37.000000000 -0500
@@ -0,0 +1,11 @@
+--- a/Makefile
++++ b/Makefile
+@@ -10,7 +10,7 @@
+ all: ${ALL}
+ 
+ uci2wb: UCI2WB.c
+-	$(CC) $(CFLAGS) $(LDFLAGS) $(CPPFLAGS) UCI2WB.c -o uci2wb
++	$(CC) $(CFLAGS) $(CPPFLAGS) UCI2WB.c -o uci2wb $(LDFLAGS)
+ 
+ install: ${ALL}
+ 	install -d -m0755 $(DESTDIR)/usr/games
diff -Nru uci2wb-2.0/debian/patches/series uci2wb-2.0/debian/patches/series
--- uci2wb-2.0/debian/patches/series	1969-12-31 19:00:00.000000000 -0500
+++ uci2wb-2.0/debian/patches/series	2014-12-16 03:00:46.000000000 -0500
@@ -0,0 +1 @@
+as-needed.patch

Reply via email to