On Mon, Dec 12, 2005 at 06:28:17PM +0100, Bernhard Reiter wrote: > On Mon, Nov 28, 2005 at 09:46:22PM +0100, Lionel Elie Mamane wrote:
>>> http://ftp.intevation.de/users/bernhard/mailman/mailman-2.1.4-avoid-headerfolding-python21.diff > I am just comparing it to 77_header_folding_in_attachments.dpatch. >> I took a look at the patch. In the class "Generator" you define, >> you completely ignore the argument mangle_from to __init__. If it >> is not used, I would expect it not to be taken as an argument of >> __init__ at all. > I accepted it as part of the promissed interface. The promised interface is that it gets set to "yes", "From " mangling gets done. If you intend not to do "From " mangling, ever, it is a bit ... "deceitful" is much much too strong, but I can't find a good word now ... to take the argument in __init__. It would confuse a user and send him in fits of debugging of why this option doesn't work. > Note that you, in replacing maxheaderlen, will not fullfill the > promise of Generator __init_ interface anymore. (...) The change in > the new patch now has a children_maxheaderlen in third position of > the __init__ arguments, which is different to what the Generator > class gave in the documentation. Yes... Maybe I should move children_maxheaderlen last and rename toplevel_maxheaderlen to just "maxheaderlen", to stay more compatible. > Note also that clone() now also does something different in a > subtile way in your patch ? It still creates a new Mailman.Generator that will not fold headers. (Unless children_maxheaderlen is given a non-default value.) > and depends on a Python version >2.2.2. Ah? I tried to find the documentation of "email" on http://www.python.org/doc/2.1.3/lib/lib.html to see whether it could be avoided, but I can't find it. Do you have a pointer to it? >> Current OpenPGP implementations do 'From '-mangling themselves >> anyway before clearsigning. I dunno whether S/MIME implementations >> do, too. > I do not know for sure either. I would assume that any reasonable > OpenPGP or S/MIME implementation would not mangle the from before > signing. PGP and GnuPG both do; GnuPG puts a "- " in front of "From " in the beginning of a line. > Otherwise it would be a "modification" of the message and the email > would contain something that the user did not write. If they don't, the signature on the message will not verify (for same cases) for no good reason. > It is a minor modification, but still it is a modification. And > maildir system can save a "From " in the body without problems and > SMTP also has no problem. Which doesn't mean that From-escaping doesn't happen some MTA's / LDA's are *very* eager and do it (nearly) all the time. -- Lionel -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]